Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handled internal error properly #352

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

kobayurii
Copy link
Member

@kobayurii kobayurii commented Sep 19, 2024

Previously trait impl<E> From<JsonRpcError<E>> for RpcError was handling only JsonRpcServerError::HandlerError therefore when proxy call returned JsonRpcServerError::InternalError it was sending a "Failed to serialize JsonRpcError" string without any actual details

closes #343

@kobayurii kobayurii self-assigned this Sep 19, 2024
@kobayurii kobayurii marked this pull request as ready for review September 19, 2024 10:08
@kobayurii
Copy link
Member Author

@race-of-sloths please, include my PR in the Race

@race-of-sloths
Copy link

race-of-sloths commented Sep 19, 2024

@kobayurii Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
King of Sloths shakes your hand! Yellow leader's jersey is yours deservedly!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@khorolets 5

Your contribution is much appreciated with a final score of 5!
You have received 53 (50 base + 5% lifetime bonus) Sloth points for this contribution

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Copy link
Member

@khorolets khorolets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@race-of-sloths score 5

@kobayurii kobayurii merged commit 30d753d into database-new Sep 19, 2024
3 checks passed
@kobayurii kobayurii deleted the fix/errors-mismatch branch October 9, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants