-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Gradle and restructure the projet #18
base: master
Are you sure you want to change the base?
Conversation
'allow-uri-read': '', | ||
'guides': "http://localhost:35729/browser-guide", | ||
'icons': 'font', | ||
'leveloffset': '+1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this feels like a hack, we should probably revisit the templates (in a future pull request).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the leveloffset, yeah b/c we turn level 2 into slides and level 3 into subslides but most sources have a level lower, i.e. 3 as subsections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could handle this case in the template but we can do that latter.
can we split the build updates and moving the files around? I can do the latter, b/c I know what each was meant for. I like your "examples" thought so we can put each file+images into a folder in examples. |
Yes we can but the build won't produce a usable browser guide until we have the proper structure (i.e. 01.adoc, 02.adoc...). |
I don’t understand. Only training guides are so large/complex that they are split up in different guides/files. In general you work on one guide at a time and want only to render that one. Only in some cases you want to render a bulk of guides. |
Oh I see so in: https://github.com/neo4j-contrib/neo4j-guides/tree/master/adoc the only browser guide is I can configure the Gradle build to ignore the other AsciiDoc documents in this directory. I thought that they were related. |
They are all "examples" that you can render to html usually we used it this way:
so you can render any file in any location and the ones provided here were just example files to test stuff out |
I'm fine with "examples" but my goal was to create a "module" that contains a complete/fully-working browser guide. For instance, template-table.adoc query-template.adoc contains useful snippets of syntax but they are not "browser guide". Also, browser.adoc relies on a local clone of the neo4j-documentation/developer-resources repository and the path does not match (anymore) the structure on the master branch.
You don't have the same flexibility with the Gradle build since you need to define tasks. I guess we could create a generic convert task that takes parameters but in my opinion that would defeat the purpose of a build tool. If we want to do that it's probably better to use the Asciidoctor CLI directly. Anyway, I will keep the files in the same place and generate a browser guide for "restaurant_recommendation.adoc" file. Is that OK? |
Structure:
Workflow:
./gradlew convert
./gradlew httpServer
:play http://localhost:35729/browser-guide/index.html