-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Gradle and restructure the projet #18
Draft
ggrossetie
wants to merge
1
commit into
neo4j-contrib:master
Choose a base branch
from
ggrossetie:gradle
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
# EditorConfig is awesome: https://EditorConfig.org | ||
root = true | ||
|
||
[*] | ||
end_of_line = lf | ||
insert_final_newline = true | ||
charset = utf-8 | ||
indent_style = space | ||
indent_size = 2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
# Ignore Gradle project-specific cache directory | ||
.gradle | ||
|
||
# Ignore Gradle build output directory | ||
build/ | ||
|
||
/node_modules/ | ||
|
||
.DS_Store | ||
|
||
/.idea/ | ||
*.iml |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
import org.asciidoctor.gradle.jvm.AsciidoctorTask | ||
import org.kordamp.gradle.livereload.LiveReloadTask | ||
|
||
plugins { | ||
id 'org.asciidoctor.jvm.gems' version '3.1.0' apply false | ||
id 'org.asciidoctor.jvm.convert' version '3.1.0' apply false | ||
id 'org.kordamp.gradle.livereload' version '0.2.1' apply false | ||
} | ||
|
||
subprojects { | ||
|
||
apply plugin: 'org.asciidoctor.jvm.gems' | ||
|
||
dependencies { | ||
asciidoctorGems 'rubygems:rouge:3.18.0' | ||
} | ||
|
||
repositories { | ||
mavenCentral() | ||
jcenter() | ||
ruby { | ||
gems() | ||
} | ||
} | ||
|
||
asciidoctorj { | ||
gemPaths "${rootProject.buildDir}/.asciidoctorGems" | ||
attributes 'allow-uri-read': '', | ||
'source-highlighter': 'rouge', | ||
'rouge-style': 'neo.forest', | ||
'presenter': 'Neo Technology', | ||
'twitter': 'neo4j', | ||
'email': '[email protected]', | ||
'currentyear': '2020', | ||
'experimental': '' | ||
} | ||
|
||
asciidoctorGemsPrepare.with { | ||
outputDir = "${rootProject.buildDir}/.asciidoctorGems" | ||
} | ||
|
||
task convert(type: AsciidoctorTask) { | ||
dependsOn asciidoctorGemsPrepare | ||
|
||
inputs.dir "${rootProject.projectDir}/templates" | ||
|
||
asciidoctorj { | ||
options template_dirs: ["${rootProject.projectDir}/templates"] | ||
attributes 'imagesdir': "http://localhost:35729/browser-guide/images", | ||
'allow-uri-read': '', | ||
'guides': "http://localhost:35729/browser-guide", | ||
'icons': 'font', | ||
'leveloffset': '+1', | ||
'env-guide': '', | ||
'guide': '', | ||
'sectanchors': '' | ||
} | ||
|
||
resources { | ||
from("${projectDir}/images") { | ||
include '**' | ||
into 'images' | ||
} | ||
} | ||
|
||
baseDir file("${projectDir}/docs") | ||
sourceDir file("${projectDir}/docs") | ||
outputDir file("${projectDir}/build/browser-guide") | ||
} | ||
|
||
task httpServer(type: LiveReloadTask) { | ||
docRoot "${projectDir}/build" | ||
} | ||
} |
Empty file.
This file was deleted.
Oops, something went wrong.
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this feels like a hack, we should probably revisit the templates (in a future pull request).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the leveloffset, yeah b/c we turn level 2 into slides and level 3 into subslides but most sources have a level lower, i.e. 3 as subsections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could handle this case in the template but we can do that latter.