Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New profile: nsxiv #6588

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

New profile: nsxiv #6588

wants to merge 3 commits into from

Conversation

amano-kenji
Copy link
Contributor

@amano-kenji amano-kenji commented Dec 27, 2024

@amano-kenji amano-kenji force-pushed the nsxiv branch 2 times, most recently from 935f21b to 83332ff Compare December 27, 2024 14:37
Comment on lines 10 to 12
include allow-bin-sh.inc

include disable-devel.inc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
include allow-bin-sh.inc
include disable-devel.inc
include allow-bin-sh.inc
noblacklist ${HOME}/.cache/nsxiv
noblacklist ${HOME}/.config/nsxiv
include disable-common.inc
include disable-devel.inc

Also, add the paths to disable-programs.inc.

And the following to "Initialization files" in disable-common.inc:

read-only ${HOME}/.config/nsxiv/exec

Note: It's important to include program-specific paths in the profiles (even if
commented) so that they are documented somewhere.

Also, note that without including disable-common.inc, the profile arguably does
not do all that much for security (as sensitive paths like ~/.bashrc and ~/.ssh
would remain available).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, add the paths to disable-programs.inc.

And the following to "Initialization files" in disable-common.inc:

read-only ${HOME}/.config/nsxiv/exec

etc/profile-m-z/nsxiv.profile Show resolved Hide resolved
amano-kenji and others added 2 commits December 31, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants