Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New profile: nsxiv #6588

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions etc/profile-m-z/nsxiv.profile
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
# Firejail profile for nsxiv
# Description: Neo Simple X Image Viewer
# This file is overwritten after every install/update
# Persistent local customizations
include nsxiv.local
# Persistent global definitions
include globals.local

# Allow /bin/sh (blacklisted by disable-shell.inc)
include allow-bin-sh.inc

include disable-devel.inc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
include allow-bin-sh.inc
include disable-devel.inc
include allow-bin-sh.inc
noblacklist ${HOME}/.cache/nsxiv
noblacklist ${HOME}/.config/nsxiv
include disable-common.inc
include disable-devel.inc

Also, add the paths to disable-programs.inc.

And the following to "Initialization files" in disable-common.inc:

read-only ${HOME}/.config/nsxiv/exec

Note: It's important to include program-specific paths in the profiles (even if
commented) so that they are documented somewhere.

Also, note that without including disable-common.inc, the profile arguably does
not do all that much for security (as sensitive paths like ~/.bashrc and ~/.ssh
would remain available).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, add the paths to disable-programs.inc.

And the following to "Initialization files" in disable-common.inc:

read-only ${HOME}/.config/nsxiv/exec

include disable-exec.inc
include disable-interpreters.inc
include disable-proc.inc
include disable-programs.inc
include disable-shell.inc
include disable-write-mnt.inc

include whitelist-run-common.inc
include whitelist-runuser-common.inc

apparmor
caps.drop all
machine-id
net none
no3d
nodvd
nogroups
noinput
nonewprivs
noprinters
noroot
nosound
notpm
notv
nou2f
novideo
seccomp
seccomp.block-secondary

private-dev
private-tmp

dbus-user none
dbus-system none

deterministic-shutdown
memory-deny-write-execute
amano-kenji marked this conversation as resolved.
Show resolved Hide resolved
Loading