chore: typecheck Deno files #2485
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't including Deno files in `tsc` typechecking, but we also weren't using any `deno` commands that typecheck. This introduces typechecking in CI and fixes resulting hidden errors. The JSON hack isn't great but really it's the whole "import a json and write new data to it" pattern that should be simplified to "just read the new data in memory", since there's no actual reason to write it to disk if you follow the code paths. It was just done that way because it was the shortest path to add the dynamic fissue annotation from the previous implementation.
When building the package, we only care about vendoring `edge-runtime/` deps, but for Deno tests/typechecking/linting, we want to vendor the deps of our build tools written in Deno too.
📊 Package size report 0.01%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works locally but running into issues with deno deps in CI... Abandoned this side quest for now.
Description
TODO
Documentation
TODO
Tests
You can test this change yourself like so:
Relevant links (GitHub issues, etc.) or a picture of cute animal
TODO