Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: typecheck Deno files #2485

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: typecheck Deno files #2485

wants to merge 2 commits into from

Commits on Jun 14, 2024

  1. chore: actually typecheck deno files, fix errors 

    We weren't including Deno files in `tsc` typechecking, but we also weren't using any `deno` commands
that typecheck.

This introduces typechecking in CI and fixes resulting hidden errors.

The JSON hack isn't great but really it's the whole "import a json and write new data to it" pattern
that should be simplified to "just read the new data in memory", since there's no actual reason to
write it to disk if you follow the code paths. It was just done that way because it was the shortest
path to add the dynamic fissue annotation from the previous implementation.
    @serhalp
    serhalp committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    4d35e6c View commit details
    Browse the repository at this point in the history

  2. chore: vendor deno deps in CI before deno tests 

    When building the package, we only care about vendoring `edge-runtime/` deps, but for Deno
tests/typechecking/linting, we want to vendor the deps of our build tools written in Deno too.
    @serhalp
    serhalp committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    cc18bdd View commit details
    Browse the repository at this point in the history