Add mappings for media keys #303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasha0552
force-pushed
the
devel
branch
4 times, most recently
from
d88067b
to
f24ef93
Compare
10 tasks
|
Any plans on merging this? |
|
Just a heads up, I have another branch that has been adapted for neutrinolabs/xrdp#3039. But those changes have not been tested yet. https://github.com/sasha0552/xorgxrdp/tree/media-keys I kind of dislike the fact that there is still special handling for certain keys. I don't have much time these days, hopefully I can carve out more time for this and PR for relative input in the next week or so. |
|
@sasha0552 - I'll pick this one up if you don't mind. I've found a few problems with neutrinolabs/xrdp#3039 in testing related directly to the (currently unused) keycode interface. I'll get those fixed in devel first. |
Merged
|
Superceded by #316 which is now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: neutrinolabs/xrdp#3022
Fixes: neutrinolabs/xrdp#1725
Fixes: #211