Move to evdev keycodes #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Status update - this is turning into more work than I expected on the xrdp side, but I'm still looking at it. |
matt335672
force-pushed
the
move_to_evdev
branch
2 times, most recently
from
2949c20
to
0b25b71
Compare
matt335672
force-pushed
the
move_to_evdev
branch
from
0b25b71
to
ad9bbf0
Compare
This commit uses the XKB rules set passed by xrdp to set up the keyboard mappings. This allows the dependency on the evdev or base keycode set to be removed from xorgxrdp, and passed to xrdp. Some other tidy-ups, mainly around the removal of magic numbers have been implemented.
matt335672
force-pushed
the
move_to_evdev
branch
from
ad9bbf0
to
050db0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211
Depends on neutrinolabs/xrdp#3138
See also #303
Uses the evdev X11 keycodes passed over from xrdp, so that these do not have to be mapped within xorgxrdp as well.
I'm hoping this is more readable than it was. I've removed a lot of magic numbers