Restructure Github actions yml file #3195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On 2024-08-05, github actions stopped working, with all jobs showing this text, or similar:- ``` Requested labels: ubuntu-latest Job defined at neutrinolabs/xrdp/.github/workflows/build.yml@... Waiting for a runner to pick this job... ``` This appears to be a recurring problem with Github runners and complex build.yml files, e.g. :- - https://github.com/orgs/community/discussions/31587 Based on the post on that thread from @swiknaba dated 2024-06-27, I've made the following changes. These are supposedly recommendations from the Github team:- 1. The runs-on: directive is specified directly under the job name, 'build_and_test', 'cppcheck' or 'code_formatting_check', e,g, :- ``` jobs: build_and_test: runs-on: ${{ matrix.os }} ``` 2. The uses: directive is always now associated with a name: directive for the same step, i,e, :- ``` - name: "Checkout" uses: actions/checkout@v4 ```
|
This worked fine in my account, but isn't working for xrdp. I'll leave it for now and try again tomorrow. |
|
Update 2024-08-06 : The actions which had previously stalled are now working on a restart. This PR may not be necessary. I'll leave it open for a bit, and close it if we don't need it. |
|
Definitely not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 2024-08-05, github actions stopped working, with all jobs showing this text, or similar:-
This appears to be a recurring problem with Github runners and complex build.yml files, e.g. :-
Based on this post from @swiknaba, I've made the following changes. These are supposedly recommendations from the Github team:-
The
runs-on:directive is specified directly under the job name, 'build_and_test', 'cppcheck' or 'code_formatting_check', e,g, :-The
uses:directive is always now associated with a name: directive for the same step, i,e, :-