Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Github actions yml file #3195

Closed
wants to merge 1 commit into from

Commits on Aug 5, 2024

  1. Restructure Github actions yml file

    On 2024-08-05, github actions stopped working, with all jobs showing
    this text, or similar:-
    
    ```
    Requested labels: ubuntu-latest
    Job defined at neutrinolabs/xrdp/.github/workflows/build.yml@...
    Waiting for a runner to pick this job...
    ```
    
    This appears to be a recurring problem with Github runners and complex
    build.yml files, e.g. :-
    
    - https://github.com/orgs/community/discussions/31587
    
    Based on the post on that thread from @swiknaba dated 2024-06-27,
    I've made the following changes. These are supposedly recommendations
    from the Github team:-
    
    1. The runs-on: directive is specified directly under the job name,
       'build_and_test', 'cppcheck' or 'code_formatting_check', e,g, :-
    
       ```
       jobs:
         build_and_test:
           runs-on: ${{ matrix.os }}
       ```
    
    2. The uses: directive is always now associated with a name:
       directive for the same step, i,e, :-
    
       ```
       - name: "Checkout"
         uses: actions/checkout@v4
       ```
    matt335672 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    cdeddae View commit details
    Browse the repository at this point in the history