[V0.10] update cppcheck and astyle #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 2.14.0 of cppcheck generates errors relating to the
check level (e.g.):-
common/base64.c:0:0: information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]
This does not happen with the same sources (commit
f781962) under 2.13.0.
This PR disables the warnings above for 2.14.0, but also allows a '-f'
argument to be passed in to request an exhaustive test. This could be used
(for example) before a major release. An exhaustive test takes a *lot*
longer. The first run with a git runner was around an hour.
The --check-level=flag was only added for 2.11.0, and so this now needs
a version check.
(cherry picked from commit 82c95fa)
- cppcheck 2.13.0 -> 2.15.0 - astyle 3.4.12 -> 3.4.14 Release notes - https://github.com/danmar/cppcheck/releases/tag/2.14.0 - https://github.com/danmar/cppcheck/releases/tag/2.14.1 - https://github.com/danmar/cppcheck/releases/tag/2.14.2 - https://github.com/danmar/cppcheck/releases/tag/2.15.0 - https://astyle.sourceforge.net/notes.html Later versions of astyle up to 3.5.1 have (currently) a problem with align-pointer=name which confuses multiplication with a pointer-dereference. See https://sourceforge.net/p/astyle/bugs/572/ (cherry picked from commit eab3cbb)
(cherry picked from commit af22422)
Remove the setting of CPPFLAGS for cppcheck v2.15.0 as this upsets the setting of FILESDIR (cherry picked from commit bc3f0e6)
metalefty
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3037