Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V0.10] update cppcheck and astyle #3232

Merged
merged 4 commits into from
Sep 5, 2024
Merged

[V0.10] update cppcheck and astyle #3232

merged 4 commits into from
Sep 5, 2024

Commits on Sep 4, 2024

  1. Allow a cppcheck check_level to be specified 

    Version 2.14.0 of cppcheck generates errors relating to the
check level (e.g.):-

    common/base64.c:0:0: information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

This does not happen with the same sources (commit
f781962) under 2.13.0.

This PR disables the warnings above for 2.14.0, but also allows a '-f'
argument to be passed in to request an exhaustive test. This could be used
(for example) before a major release. An exhaustive test takes a *lot*
longer. The first run with a git runner was around an hour.

The --check-level=flag was only added for 2.11.0, and so this now needs
a version check.

(cherry picked from commit 82c95fa)
    @matt335672
    matt335672 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    7288c18 View commit details
    Browse the repository at this point in the history

  2. Bump CI tools versions 

    - cppcheck 2.13.0 -> 2.15.0
- astyle 3.4.12 -> 3.4.14

Release notes
- https://github.com/danmar/cppcheck/releases/tag/2.14.0
- https://github.com/danmar/cppcheck/releases/tag/2.14.1
- https://github.com/danmar/cppcheck/releases/tag/2.14.2
- https://github.com/danmar/cppcheck/releases/tag/2.15.0
- https://astyle.sourceforge.net/notes.html

Later versions of astyle up to 3.5.1 have (currently) a problem with
align-pointer=name which confuses multiplication with a
pointer-dereference. See https://sourceforge.net/p/astyle/bugs/572/

(cherry picked from commit eab3cbb)
    @matt335672
    matt335672 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2d8ebf4 View commit details
    Browse the repository at this point in the history

  3. Make scripts/install_cppcheck.sh shellcheck-compatible 

    (cherry picked from commit af22422)
    @matt335672
    matt335672 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    03659cf View commit details
    Browse the repository at this point in the history

  4. Update scripts/install_cppcheck.sh for v2.15.0 

    Remove the setting of CPPFLAGS for cppcheck v2.15.0 as this
upsets the setting of FILESDIR

(cherry picked from commit bc3f0e6)
    @matt335672
    matt335672 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    eaf32ed View commit details
    Browse the repository at this point in the history