Public page shares

[mejo-]

📝 Summary

• Allow to share pages as links (along with their subpages)
• Add page sidebar "share" tab to manage link shares
• Move management of collective share links into page sidebar of landingpage
• Resolves: Add support for public shares of pages #515
• Resolves: Allow multiple share links with different edit rights #633

🖼️ Screenshots

🏚️ Collective actions before	🏡 Collective actions after

'Share' sidebar tab	Configure share permissions

Screencast (slightly outdated)

🚧 TODO

• backend:
  • share parent folder if pageId is index page
  • implement checkPagePermissions() in PublicPageController
  • implement `findChildren() in PageService
  • add support for single-page share
  • check consequences of adding subpage in single-page shares
  • allow to create several shares
  • make sure move/copy page cannot break out of share realm
• frontend:
  • add share tab in page sidebar
  • add options to edit share permissions
  • move share collective to landingpage page sidebar
  • add link pointing to sidebar to collective actions
• UI adjustments
  • don't show trash
  • hide 'delete page' options in UI
  • adjust move/copy page picker
• make sure mountpoint works
• behat tests:
  • add/get/delete single-page share
  • fix attachment check
  • add/get/delete page folder share
  • fail to trash page in page share
  • fail to get/create/touch/move/setEmoji/setSubpageOrder/getAttachments/getBacklinks page outside page share
• cypress tests:
  • create read-only collective share, open (read-only)
  • update collective share to editable, open, edit
  • delete collective share
  • create read-only page share, open (read-only)
  • update page share to editable
  • delete page share

🏁 Checklist

• Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
• Sign-off message is added to all commits
• Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
• Documentation is not required

[cypress]

Passing run #1318 ↗︎

0

268

0

0

0

Details:

Public page shares
Project: Collectives	Commit: e5c2985850
Status: Passed	Duration: 06:26 💡
Started: Dec 20, 2023 11:29 AM	Ended: Dec 20, 2023 11:36 AM

Review all test suite changes for PR #1041 ↗︎

[mejo-]

• add support for single-page share

This is about sharing pages that don't have a subpage yet. Unfortunately it's not so easy given that right now pages without a subpage are single markdown files (e.g. page.md) and not inside a folder (e.g. page/Readme.md). This leads to problems when sharing the page without subpages and afterwards creating a subpage of it. The markdown file will be replaced and the underlying file share will no longer be valid.

I think we should just do the following:

• Get rid of the backend code that reverts subfolder into single markdown files altogether.
• Before sharing a single markdown file, move it into the page/Readme.md structure like we do here.

This is a first step in migrating away from the mix of page.md and page/Readme.md to only use the second format, which we discussed earlier and I consider a good thing in terms of consistency anyway (e.g. attachments then always reside in the page folder, not in the parent page folder).

What do you think @max-nextcloud?

[max-nextcloud]

What do you think @max-nextcloud?

@mejo- sounds like a good approach to me.

(e.g. attachments then always reside in the page folder, not in the parent page folder).

I thought they'd always live in a .attachments.${fileId} folder. But i guess that folder is either in the parent folder or in the same folder as the file itself (Readme.md)

[mejo-]

I thought they'd always live in a .attachments.${fileId} folder. But i guess that folder is either in the parent folder or in the same folder as the file itself (Readme.md)

Exactly 😉

[nimishavijay]

Super nice improvement! It looks great, only 2 small changes:

• use a different icon for the copy button. My suggestion is the copy MDI icon.
• unsure about wording "Manage share links" maybe just "Share" works?

This is maybe a bigger discussion, but I wonder if it makes sense to combine the "Manage members" and "Manage sharing" to some degree. Both of those things are regarding who has access to the collective/page. This could be as simple as showing the members of the collective in the sharing tab as a "People with access" section (similar to the "Others with access" in the Files sharing) where there is also a button to "Manage members". But that's definitely a follow-up topic :)

[punkyard]

hi,
and could you add shares for each page? both public and internal shares in drop down menu, please
happy new year!

[gymnae]

Second that question: The mockups in OP show a nice single page sharing dialogue, but it appears absent in the version shipped with NC 28