Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency flutter to v3.24.2 - autoclosed #2399

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 16, 2024

This PR contains the following updates:

Package Update Change
flutter (source) minor 3.22.3 -> 3.24.2

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

flutter/flutter (flutter)

v3.24.2

Compare Source

v3.24.1

Compare Source

  • dart/56464 - Fixes resolving include: in analysis_options.yaml file in a nested folder in the workspace.
  • dart/56423 - Fixes source maps generated by dart compile wasm when optimizations are enabled.
  • dart/56374 - Fixes a bug in the dart2wasm compiler in unsound -O3 / -O4 modes where a implicit setter for a field of generic type will store null instead of the field value.
  • dart/56440 - Fixes a bug in the dart2wasm compiler that can trigger in certain situations when using partial instantiations of generic tear-offs (constructors or static methods) in constant expressions.
  • dart/56457 - The algorithm for computing the standard upper bound of two types, also known as UP, is provided the missing implementation for StructuralParameterType objects. In some corner cases the lacking implementation resulted in a crash of the compiler.
  • flutter/152047 - [Web] Fixes an issue in Flutter Web apps where when semantics are enabled, tapping on the label of a checkbox in a mobile browser won't togle the checkbox.
  • flutter/153308 - [Web] Adds source map support in flutter run / flutter build for dart2wasm for debugging in Chrome DevTools.
  • flutter/54446 - [Web] Fixes an issue in Flutter Web apps where the app may crash if CanvasKit is loaded from the network instead of a cache.
  • flutter/152955 - [Impeller] Fixes an issue where when using unbound saveLayers rendering issues would occur.
  • flutter/153037 - [Impeller] Fixes an issue where RTL glyphs would render incorrectly.
  • flutter/153038 - [Impeller] Fixes an issue where padding would be applied incorrectly in Canvas.drawVerticies when using texture coordinates.
  • flutter/153041 - [Impeller] Fixes an rare issue causing applications to crash when using platform views on older iPhones.
  • flutter/153188 - [Impeller] Fixes a rendering issue on iOS devices using Impeller where clips do not appear around entities drawn with certain advanced blend modes.
  • flutter/54513 - [iOS/MacOS] Fixes an issue preventing iOS Apps Store validation from failing for Flutter apps using Xcode versions before Xcode 16.
  • flutter/54518 - Fixes an issue on OpenGL ES devices where a black screen would appear instead of the Flutter app output.
  • flutter/153117 [iOS/MacOS] Fixes an issue where compilation errors are not displayed in the output of flutter run when using Xcode 16.
  • flutter/153321 - [Desktop] Fixes an issue where older Windows devices could not run Flutter apps built using Flutter 3.21 or later.
  • flutter/153294 [Tool] Fixes an issue in the Flutter tool streamlining the crash message that occurs when running flutter run -d chrome and Chrome is closed before Flutter tries to close it.
  • flutter/153579 [Tool] Fixes an issue where users would experience large crash messages when flutter run or flutter debug-adapter are unable to connect to the Flutter web app.

v3.24.0

Compare Source

Initial stable release.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@Leptopoda Leptopoda marked this pull request as draft August 16, 2024 07:15
@Leptopoda
Copy link
Member

We'll need to wait until #2391 is resolved

@renovate renovate bot changed the title chore(deps): update dependency flutter to v3.24.0 chore(deps): update dependency flutter to v3.24.1 Aug 21, 2024
@Leptopoda Leptopoda self-assigned this Aug 23, 2024
@provokateurin provokateurin marked this pull request as ready for review August 29, 2024 07:21
@provokateurin
Copy link
Member

For some reason I can not reproduce the analyzer errors locally. I think all of them are valid though

@Leptopoda
Copy link
Member

No they aren't valid. Custom lint should not run in the nc package.

Is the analyzer process now running globally?
I do have a local branch testing pub workspaces where I fixed these analyzer issues.

I can push it this evening as a draft.

@provokateurin
Copy link
Member

Yeah it is running globally as it always has. I thought we should just disable the custom rules for those packages?

@Leptopoda
Copy link
Member

I just took a look and you are right.
It comes down to just disabling the lint rule in the required packages.

custom_lint:
  rules:
    - prefer_prefixed_nextcloud_import: false

@provokateurin
Copy link
Member

Ok, but the problem is I don't get any of the lints locally. I also don't understand why we didn't see them before

@Leptopoda
Copy link
Member

Probably because custom lint is startes by the analyzer/ide per package it is used and not globally.

@provokateurin
Copy link
Member

But I also run melos run analyze just like the CI does and it doesn't show me anything.

@Leptopoda
Copy link
Member

I am able to reproduce the lints when using pub workspaces but tbh I wouldn't run to rush it (it isn't officially stable and melos doesn't support it yet)

@provokateurin
Copy link
Member

But there is no other way to move forward. Then we're just stuck and we will miss out on more and more dependency updates.

Copy link
Contributor Author

renovate bot commented Aug 31, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@provokateurin
Copy link
Member

So I with flutter master I don't see the lints locally, but the CI also no longer sees them. Not sure if that is better or worse than before.

Copy link

codecov bot commented Aug 31, 2024

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Project coverage is 29.90%. Comparing base (4ce78c1) to head (68aaf48).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
packages/neon_framework/lib/src/pages/home.dart 0.00% 6 Missing ⚠️
...kages/neon_framework/lib/src/pages/login_flow.dart 0.00% 6 Missing ⚠️
...neon_framework/lib/src/pages/account_settings.dart 0.00% 1 Missing ⚠️
...n_framework/lib/src/widgets/custom_background.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2399      +/-   ##
==========================================
+ Coverage   29.87%   29.90%   +0.03%     
==========================================
  Files         332      332              
  Lines      124330   124391      +61     
==========================================
+ Hits        37138    37195      +57     
- Misses      87192    87196       +4     
Flag Coverage Δ *Carryforward flag
account_repository 99.64% <ø> (ø)
cookie_store 99.48% <ø> (-0.52%) ⬇️
dashboard_app 96.05% <ø> (ø)
dynamite 31.08% <ø> (ø)
dynamite_end_to_end_test 61.69% <ø> (ø)
dynamite_runtime 85.40% <ø> (ø)
neon_dashboard 96.05% <ø> (ø) Carriedforward from 4ce78c1
neon_framework 43.51% <0.00%> (-0.04%) ⬇️
neon_http_client 93.28% <ø> (ø)
neon_notifications 100.00% <ø> (ø) Carriedforward from 4ce78c1
neon_talk 99.45% <ø> (ø) Carriedforward from 4ce78c1
nextcloud 25.88% <ø> (ø)
notifications_app 100.00% <ø> (ø)
sort_box 90.90% <ø> (ø)
talk_app 99.09% <100.00%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...s/neon_framework/lib/src/utils/global_options.dart 0.00% <ø> (ø)
...ackages/neon_framework/lib/src/widgets/drawer.dart 62.96% <ø> (ø)
...ramework/packages/talk_app/lib/src/pages/room.dart 100.00% <100.00%> (ø)
...ork/packages/talk_app/lib/src/widgets/message.dart 99.00% <100.00%> (ø)
...neon_framework/lib/src/pages/account_settings.dart 0.00% <0.00%> (ø)
...n_framework/lib/src/widgets/custom_background.dart 0.00% <0.00%> (ø)
packages/neon_framework/lib/src/pages/home.dart 0.00% <0.00%> (ø)
...kages/neon_framework/lib/src/pages/login_flow.dart 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

@provokateurin provokateurin changed the title chore(deps): update dependency flutter to v3.24.1 chore(deps): update dependency flutter to v3.25.0-0.1.pre Aug 31, 2024
@provokateurin provokateurin self-requested a review August 31, 2024 07:47
@provokateurin
Copy link
Member

Stupid renovate

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until @Leptopoda tested and reviewed

@provokateurin
Copy link
Member

Ok I'll make my own PR lol

@provokateurin provokateurin marked this pull request as draft August 31, 2024 07:49
@provokateurin provokateurin changed the title chore(deps): update dependency flutter to v3.25.0-0.1.pre chore(deps): update dependency flutter to v3.24.1 Aug 31, 2024
@renovate renovate bot changed the title chore(deps): update dependency flutter to v3.24.1 chore(deps): update dependency flutter to v3.24.2 Sep 4, 2024
@renovate renovate bot changed the title chore(deps): update dependency flutter to v3.24.2 chore(deps): update dependency flutter to v3.24.2 - autoclosed Sep 5, 2024
@renovate renovate bot closed this Sep 5, 2024
@renovate renovate bot deleted the renovate/flutter-3.x branch September 5, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants