-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency flutter to v3.24.2 - autoclosed #2399
Conversation
We'll need to wait until #2391 is resolved |
90ef187
to
c1dbb68
Compare
c1dbb68
to
5803d66
Compare
5803d66
to
639d02d
Compare
For some reason I can not reproduce the analyzer errors locally. I think all of them are valid though |
No they aren't valid. Custom lint should not run in the nc package. Is the analyzer process now running globally? I can push it this evening as a draft. |
Yeah it is running globally as it always has. I thought we should just disable the custom rules for those packages? |
I just took a look and you are right. custom_lint:
rules:
- prefer_prefixed_nextcloud_import: false |
Ok, but the problem is I don't get any of the lints locally. I also don't understand why we didn't see them before |
Probably because custom lint is startes by the analyzer/ide per package it is used and not globally. |
But I also run |
I am able to reproduce the lints when using pub workspaces but tbh I wouldn't run to rush it (it isn't officially stable and melos doesn't support it yet) |
But there is no other way to move forward. Then we're just stuck and we will miss out on more and more dependency updates. |
639d02d
to
90f2834
Compare
90f2834
to
38e19bf
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
38e19bf
to
68aaf48
Compare
So I with flutter master I don't see the lints locally, but the CI also no longer sees them. Not sure if that is better or worse than before. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2399 +/- ##
==========================================
+ Coverage 29.87% 29.90% +0.03%
==========================================
Files 332 332
Lines 124330 124391 +61
==========================================
+ Hits 37138 37195 +57
- Misses 87192 87196 +4
*This pull request uses carry forward flags. Click here to find out more.
|
68aaf48
to
c3dce52
Compare
c3dce52
to
94c08e6
Compare
Stupid renovate |
94c08e6
to
c3dce52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking until @Leptopoda tested and reviewed
c3dce52
to
844cc73
Compare
Ok I'll make my own PR lol |
844cc73
to
d3bc98c
Compare
This PR contains the following updates:
3.22.3
->3.24.2
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
flutter/flutter (flutter)
v3.24.2
Compare Source
v3.24.1
Compare Source
include:
inanalysis_options.yaml
file in a nested folder in the workspace.dart compile wasm
when optimizations are enabled.dart2wasm
compiler in unsound-O3
/-O4
modes where a implicit setter for a field of generic type will store null instead of the field value.dart2wasm
compiler that can trigger in certain situations when using partial instantiations of generic tear-offs (constructors or static methods) in constant expressions.StructuralParameterType
objects. In some corner cases the lacking implementation resulted in a crash of the compiler.flutter run
/flutter build
fordart2wasm
for debugging in Chrome DevTools.saveLayers
rendering issues would occur.Canvas.drawVerticies
when using texture coordinates.flutter run
when using Xcode 16.flutter run -d chrome
and Chrome is closed before Flutter tries to close it.flutter run
orflutter debug-adapter
are unable to connect to the Flutter web app.v3.24.0
Compare Source
Initial stable release.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.