Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nextcloud)!: Move RichObjectParameter from spreed to core and fix rich parameter typing for broken apps #2501

Merged
merged 1 commit into from
Sep 15, 2024

fix(nextcloud)!: Move RichObjectParameter from spreed to core and fix…

f4fd9cf
Select commit
Loading
Failed to load commit list.
Merged

fix(nextcloud)!: Move RichObjectParameter from spreed to core and fix rich parameter typing for broken apps #2501

fix(nextcloud)!: Move RichObjectParameter from spreed to core and fix…
f4fd9cf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 15, 2024 in 0s

28.37% (-1.90%) compared to 2abdd80

View this Pull Request on Codecov

28.37% (-1.90%) compared to 2abdd80

Details

Codecov Report

Attention: Patch coverage is 9.12779% with 448 lines in your changes missing coverage. Please review.

Project coverage is 28.37%. Comparing base (2abdd80) to head (f4fd9cf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ges/nextcloud/lib/src/api/core/core.openapi.g.dart 0.24% 402 Missing ⚠️
...s/nextcloud/lib/src/api/spreed/spreed.openapi.dart 25.00% 18 Missing ⚠️
...kages/nextcloud/lib/src/api/core/core.openapi.dart 37.03% 17 Missing ⚠️
...src/api/notifications/notifications.openapi.g.dart 33.33% 8 Missing ⚠️
...nextcloud/lib/src/api/spreed/spreed.openapi.g.dart 66.66% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2501      +/-   ##
==========================================
- Coverage   30.27%   28.37%   -1.90%     
==========================================
  Files         352      352              
  Lines      124321   135904   +11583     
==========================================
+ Hits        37632    38560     +928     
- Misses      86689    97344   +10655
Files with missing lines Coverage Δ
...ork/packages/talk_app/lib/src/widgets/message.dart 99.00% <100.00%> (+<0.01%) ⬆️
...alk_app/lib/src/widgets/rich_object/deck_card.dart 100.00% <ø> (ø)
...talk_app/lib/src/widgets/rich_object/fallback.dart 100.00% <ø> (ø)
...ges/talk_app/lib/src/widgets/rich_object/file.dart 100.00% <100.00%> (ø)
.../talk_app/lib/src/widgets/rich_object/mention.dart 100.00% <100.00%> (ø)
...b/src/api/notifications/notifications.openapi.dart 56.02% <100.00%> (-4.60%) ⬇️
...nextcloud/lib/src/api/spreed/spreed.openapi.g.dart 14.38% <66.66%> (-0.81%) ⬇️
...src/api/notifications/notifications.openapi.g.dart 30.68% <33.33%> (-3.31%) ⬇️
...kages/nextcloud/lib/src/api/core/core.openapi.dart 39.99% <37.03%> (-5.46%) ⬇️
...s/nextcloud/lib/src/api/spreed/spreed.openapi.dart 32.29% <25.00%> (-0.85%) ⬇️
... and 1 more

... and 8 files with indirect coverage changes

View more details on Codecov