Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin audit app: optimization according to PHP 8 #38176

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Admin audit app: optimization according to PHP 8 #38176

merged 1 commit into from
Jul 5, 2023

Conversation

danialRahimy
Copy link
Contributor

@danialRahimy danialRahimy commented May 10, 2023 •
edited by ChristophWurst
Loading

Summary

optimization according to PHP 8 in the admin audit app.

Checklist

@tcitworld
Copy link
Member

It seems your branch has derived a lot from current master. Can you make things clean?

@danialRahimy danialRahimy reopened this May 10, 2023
@szaimen szaimen added the 3. to review Waiting for reviews label May 10, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone May 10, 2023
@danialRahimy
Copy link
Contributor Author

It seems your branch has derived a lot from current master. Can you make things clean?

I did this.
Thanks.

@danialRahimy
Copy link
Contributor Author

@tcitworld

ChristophWurst removed reviewers, and according to the rules At least 2 approving reviews are required by reviewers with write access. What should I do?

@tcitworld tcitworld requested review from a team, icewind1991, blizzz and come-nc and removed request for a team July 3, 2023 08:07
@tcitworld
Copy link
Member

Wait for new reviewers to come-up. No hurries. :)

ChristophWurst
ChristophWurst approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits into one

@danialRahimy danialRahimy force-pushed the master branch 2 times, most recently from 42509b6 to 5d28834 Compare July 5, 2023 10:58
@danialRahimy
Copy link
Contributor Author

Please squash your commits into one

I committed my changes on the master, and I pull the master after my first commit and so I can't squash all of my commits into one. I just squash two last ones.

@ChristophWurst
Copy link
Member

Squashed the commits for you

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 5, 2023
@blizzz blizzz merged commit 79d24bf into nextcloud:master Jul 5, 2023
37 of 38 checks passed
@welcome
Copy link

welcome bot commented Jul 5, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc left review comments

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@blizzz blizzz blizzz approved these changes

@tcitworld tcitworld tcitworld approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: admin audit technical debt
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
6 participants
@danialRahimy @tcitworld @ChristophWurst @blizzz @come-nc @szaimen