Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use unique names for actions upload-artifact #1397

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Sep 29, 2024

At https://github.com/nextcloud/tables/actions/runs/11089354255?pr=1396, we have the error Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run. This is an attempt to fix it.

@enjeck enjeck self-assigned this Sep 29, 2024
@blizzz
Copy link
Member

blizzz commented Sep 30, 2024

Seems related: actions/upload-artifact#480

v3 will be expired on Nov 30.

Better way might be as suggested here: actions/upload-artifact#481 (comment)

@enjeck enjeck force-pushed the update-workflow branch 4 times, most recently from b4f3134 to 7a7a280 Compare October 2, 2024 15:36
@enjeck enjeck mentioned this pull request Oct 4, 2024
@enjeck enjeck force-pushed the update-workflow branch 2 times, most recently from cddee02 to 012fbd2 Compare October 4, 2024 08:49
@enjeck
Copy link
Contributor Author

enjeck commented Oct 4, 2024

Seems related: actions/upload-artifact#480

v3 will be expired on Nov 30.

Better way might be as suggested here: actions/upload-artifact#481 (comment)

Thanks @blizzz . That helps.
There are now some failing tests here that pass locally, so it's tough figuring out what's up

@enjeck enjeck changed the title fix: use actions upload-artifact v3 instead of v4 fix: use unique names for actions upload-artifact Oct 4, 2024
@blizzz
Copy link
Member

blizzz commented Oct 8, 2024

The failing tests fail for me locally as well. But what is confusing is that we did not have recent merges.

@blizzz
Copy link
Member

blizzz commented Oct 8, 2024

there is nothing with a .paragraph-content

Screenshot_20241008_125331

@blizzz
Copy link
Member

blizzz commented Oct 8, 2024

Okay, I suppose that was removed in Text (as it is in text wrapper): nextcloud/text#6425

@blizzz blizzz merged commit d2f19ee into main Oct 8, 2024
55 checks passed
@blizzz blizzz deleted the update-workflow branch October 8, 2024 11:25
@blizzz
Copy link
Member

blizzz commented Oct 8, 2024

/backport to stable0.8

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Oct 8, 2024
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants