Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use unique names for actions upload-artifact #1397

Merged
merged 2 commits into from
Oct 8, 2024
+7 −7
Merged

fix: use unique names for actions upload-artifact #1397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa30985
fix(Workflow): use unique artifact name
enjeck Oct 4, 2024
3d44745
test(cypress): update selector for tables description
blizzz Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/cypress-custom.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,24 +149,24 @@ jobs:
CYPRESS_ncVersion: ${{ matrix.server-versions }}
npm_package_name: ${{ env.APP_NAME }}

- name: Print logs
- name: Print logs ${{ matrix.node-version }}-${{ matrix.php-versions }}-${{ matrix.server-versions }}-${{ matrix.databases }}
if: always()
run: |
cat /tmp/requestlog
cat data/nextcloud.log

- name: Upload test failure screenshots
- name: Upload test failure screenshots ${{ matrix.node-version }}-${{ matrix.php-versions }}-${{ matrix.server-versions }}-${{ matrix.databases }}
uses: actions/upload-artifact@v4
if: failure()
with:
name: Upload screenshots
name: Upload screenshots ${{ matrix.node-version }}-${{ matrix.php-versions }}-${{ matrix.server-versions }}-${{ matrix.databases }}
path: apps/${{ env.APP_NAME }}/cypress/screenshots/
retention-days: 5

- name: Upload nextcloud logs
- name: Upload nextcloud logs ${{ matrix.node-version }}-${{ matrix.php-versions }}-${{ matrix.server-versions }}-${{ matrix.databases }}
uses: actions/upload-artifact@v4
if: failure()
with:
name: Upload nextcloud log
name: Upload nextcloud log ${{ matrix.node-version }}-${{ matrix.php-versions }}-${{ matrix.server-versions }}-${{ matrix.databases }}
path: data/nextcloud.log
retention-days: 5
4 changes: 2 additions & 2 deletions cypress/e2e/tables-table.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ describe('Manage a table', () => {
cy.contains('button', 'Create row').should('be.visible')
cy.contains('h1', 'to do list').should('be.visible')
cy.contains('table th', 'Task').should('exist')
cy.contains('.paragraph-content', 'to Do List description').should('be.visible')
cy.contains('.text-editor__content p', 'to Do List description').should('be.visible')
})

it('Create with import', () => {
Expand Down Expand Up @@ -71,7 +71,7 @@ describe('Manage a table', () => {

cy.wait(10).get('.toastify.toast-success').should('be.visible')
cy.get('.app-navigation__list').contains('ToDo list').should('exist')
cy.contains('.paragraph-content', 'Updated ToDo List description').should('be.visible')
cy.contains('.text-editor__content p', 'Updated ToDo List description').should('be.visible')
})

it('Delete', () => {
Expand Down
Loading