Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: New clades subcommand that works like traits, using labeled tips rather than clades.tsv #1329

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Oct 24, 2023

  1. feat: add clades2 command that works like traits

    Currently, to assign clades at internal nodes, we require a `clades.tsv`
    which isn't a natural way to define clades in most cases
    
    Rather, one often wants to infer clades from a set of labeled tips
    
    This PR adds a new subcommand `clades2` to infer clades at all tips and internal nodes
    from a subset of labeled tips
    
    Currently, the implementation is a stripped down version of `traits`
    with confidence/entropy/model output removed
    But this is an implementation detail that might change in the future
    
    Some limitations of the current approach:
    - clades can be non-monophyletic
    - hierarchy information is not taken into account (i.e. the internal node at a junction of A, A.1.1 and A.1.2 will not be A.1 but one of the other three)
    
    In theory, hierarchy could be taken into account but this may not be required for this command to be useful already.
    
    The name is provisional, I couldn't immediately think of a good one so I went for `clades2`.
    corneliusroemer committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    224c41c View commit details
    Browse the repository at this point in the history