Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed comment im changeo_convertdb_fasta #288

Merged
merged 1 commit into from
Feb 8, 2024
Merged

fixed comment im changeo_convertdb_fasta #288

merged 1 commit into from
Feb 8, 2024

Conversation

mapo9
Copy link
Contributor

@mapo9 mapo9 commented Nov 24, 2023

small correction of a comment that confused me a lot when trying to figure out what the module was doing

  • This comment contains a description of changes (with reason).

@mapo9 mapo9 requested a review from ggabernet November 24, 2023 09:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 24, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit f8f958c

+| ✅ 158 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-11-24 09:16:30

@mapo9
Copy link
Contributor Author

mapo9 commented Nov 24, 2023

This obviosuly doesnt need its own PR. Just made it that its get kept in mind maybe for the next releases

@mapo9 mapo9 marked this pull request as draft December 11, 2023 07:48
ggabernet
ggabernet approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 sorry about that! 😄

@ggabernet ggabernet marked this pull request as ready for review February 8, 2024 03:17
@ggabernet ggabernet merged commit dd0ef85 into nf-core:dev Feb 8, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggabernet ggabernet ggabernet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mapo9 @ggabernet