Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyrodigal channels, update ampcombi docs #300

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Conversation

jasmezz
Copy link
Collaborator

@jasmezz jasmezz commented Aug 4, 2023

  • Pyrodigal channels were not called correctly, leading to wrong files submitted to antiSMASH
  • Mention DRAMP database in AMPcombi docs

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/funcscan branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jasmezz jasmezz requested a review from a team August 4, 2023 14:56
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 751fa03

+| ✅ 157 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-08-04 15:01:18

@jasmezz jasmezz merged commit 1e3649e into dev Aug 4, 2023
16 of 24 checks passed
@jasmezz jasmezz deleted the fix_antismash_ampcombi branch August 4, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants