Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch: 3.2.1 #710

Merged
merged 8 commits into from
Oct 30, 2024
Merged

Patch: 3.2.1 #710

merged 8 commits into from
Oct 30, 2024

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Oct 29, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

jfy133
jfy133 commented Oct 29, 2024
View reviewed changes
.nf-core.yml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit daa493f

+| ✅ 321 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file [TODO: try and test using for --host_fasta and --host_genome]
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-10-30 09:18:09

@jfy133 jfy133 requested a review from d4straub October 29, 2024 14:27
d4straub
d4straub approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

conf/modules.config Outdated Show resolved Hide resolved
itrujnara
itrujnara approved these changes Oct 29, 2024
View reviewed changes
Copy link

@itrujnara itrujnara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely one of the patches ever created. Looks good to me.

jfy133
jfy133 commented Oct 30, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jfy133 jfy133 mentioned this pull request Oct 30, 2024
Closed
@jfy133 jfy133 merged commit b582aae into master Oct 30, 2024
24 checks passed
@jfy133 jfy133 deleted the patch branch October 30, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

@matthdsm matthdsm matthdsm approved these changes

@atrigila atrigila atrigila approved these changes

@d4straub d4straub d4straub approved these changes

@itrujnara itrujnara itrujnara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jfy133 @mashehu @matthdsm @atrigila @d4straub @itrujnara