Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: arriba: rename argument and reorder alphabetically #7255

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

rannick
Copy link
Contributor

@rannick rannick commented Dec 20, 2024

PR checklist

Rename argument to fix language server issues, use wave containers

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@rannick rannick requested a review from atrigila January 14, 2025 16:40
@@ -1,3 +1,8 @@
profiles {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be needed now. The issues with the CI runners have been resolved. Can you kindly remove this and retry the CI tests.

@@ -0,0 +1,5 @@
profiles {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above! Thank you!

@GallVp
Copy link
Member

GallVp commented Jan 15, 2025

Looks good. Thank you for the contribution.

'biocontainers/arriba:2.4.0--h0033a41_2' }"

'https://community-cr-prod.seqera.io/docker/registry/v2/blobs/sha256/3b/3b54fa9135194c72a18d00db6b399c03248103f87e43ca75e4b50d61179994b3/data' :
'community.wave.seqera.io/library/wget:1.21.4--8b0fcde81c17be5e' }"
input:
val(genome)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is genome used in the wget command? Perhaps we could pass the path to the arriba database. Therefore, if the datbaase path changes or is updated (e.g. arriba_v2.5.0), we don't have to update the hardcoded https://github.com/suhrig/arriba/releases/download/v2.4.0/arriba_v2.4.0.tar.gz -O arriba_v2.4.0.tar.gz in the module, we just have to pass a new val(arriba_database).

So then, it would be: wget $arriba_database

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants