-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: arriba: rename argument and reorder alphabetically #7255
base: master
Are you sure you want to change the base?
Changes from 25 commits
4a2a3c1
0ab0de1
8bd5788
cbce6e2
0cc3756
2323920
587fe65
749020c
59c9670
9c6234f
1fe4e01
3ebd8df
be44556
daed1da
a3544f7
7589d79
77c54c5
825daa0
bca7139
9ff58ba
4bf715f
3a9ca68
f3ae3f8
e0d8062
eabdf7a
8b6e72e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,4 @@ channels: | |
- conda-forge | ||
- bioconda | ||
dependencies: | ||
- bioconda::arriba=2.4.0 | ||
- conda-forge::wget=1.21.4 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,9 +4,8 @@ process ARRIBA_DOWNLOAD { | |
|
||
conda "${moduleDir}/environment.yml" | ||
container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ? | ||
'https://depot.galaxyproject.org/singularity/arriba:2.4.0--h0033a41_2' : | ||
'biocontainers/arriba:2.4.0--h0033a41_2' }" | ||
|
||
'https://community-cr-prod.seqera.io/docker/registry/v2/blobs/sha256/3b/3b54fa9135194c72a18d00db6b399c03248103f87e43ca75e4b50d61179994b3/data' : | ||
'community.wave.seqera.io/library/wget:1.21.4--8b0fcde81c17be5e' }" | ||
input: | ||
val(genome) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How is genome used in the wget command? Perhaps we could pass the path to the arriba database. Therefore, if the datbaase path changes or is updated (e.g. arriba_v2.5.0), we don't have to update the hardcoded So then, it would be: |
||
|
||
|
@@ -30,20 +29,20 @@ process ARRIBA_DOWNLOAD { | |
|
||
cat <<-END_VERSIONS > versions.yml | ||
"${task.process}": | ||
arriba_download: \$(arriba -h | grep 'Version:' 2>&1 | sed 's/Version:\s//') | ||
wget: \$(wget --version | head -1 | sed 's/GNU Wget //' | sed -E 's/(.*) built on darwin.*/\1/') | ||
END_VERSIONS | ||
""" | ||
|
||
stub: | ||
""" | ||
touch blacklist_hg38_GRCh38_v2.4.0.tsv.gz | ||
touch protein_domains_hg38_GRCh38_v2.4.0.gff3 | ||
touch cytobands_hg38_GRCh38_v2.4.0.tsv | ||
touch protein_domains_hg38_GRCh38_v2.4.0.gff3 | ||
touch known_fusions_hg38_GRCh38_v2.4.0.tsv.gz | ||
|
||
cat <<-END_VERSIONS > versions.yml | ||
"${task.process}": | ||
arriba_download: \$(arriba -h | grep 'Version:' 2>&1 | sed 's/Version:\s//') | ||
wget: \$(wget --version | head -1 | sed 's/GNU Wget //' | sed -E 's/(.*) built on darwin.*/\1/') | ||
END_VERSIONS | ||
""" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
profiles { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above! Thank you! |
||
docker { | ||
docker.runOptions = '-u $(id -u):$(id -g)' | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be needed now. The issues with the CI runners have been resolved. Can you kindly remove this and retry the CI tests.