Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: arriba: rename argument and reorder alphabetically #7255

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
4a2a3c1
rename argument and reorder alphabetically
rannick Dec 20, 2024
0ab0de1
add docker permission fix
rannick Dec 20, 2024
8bd5788
include config
rannick Dec 20, 2024
cbce6e2
use example config creation
rannick Dec 20, 2024
0cc3756
Merge branch 'master' into fix_arriba
rannick Jan 7, 2025
2323920
update test snap
rannick Jan 7, 2025
587fe65
Merge branch 'fix_arriba' of https://github.com/rannick/modules into …
rannick Jan 7, 2025
749020c
update snapshorts and test input format
rannick Jan 7, 2025
59c9670
update snapshot, update containers
rannick Jan 7, 2025
9c6234f
Merge branch 'master' into fix_arriba
rannick Jan 7, 2025
1fe4e01
update versions md5sum
rannick Jan 7, 2025
3ebd8df
Merge branch 'fix_arriba' of https://github.com/rannick/modules into …
rannick Jan 7, 2025
be44556
update meta and container for arriba/arriba
rannick Jan 7, 2025
daed1da
modify config
rannick Jan 7, 2025
a3544f7
Merge branch 'master' into fix_arriba
rannick Jan 7, 2025
7589d79
for download, use wget
rannick Jan 7, 2025
77c54c5
Merge branch 'fix_arriba' of https://github.com/rannick/modules into …
rannick Jan 7, 2025
825daa0
update version in snap
rannick Jan 7, 2025
bca7139
update download container
rannick Jan 14, 2025
9ff58ba
Merge branch 'master' into fix_arriba
rannick Jan 14, 2025
4bf715f
update snap
rannick Jan 14, 2025
3a9ca68
update conda env
rannick Jan 14, 2025
f3ae3f8
update conda env
rannick Jan 14, 2025
e0d8062
handle other build
rannick Jan 14, 2025
eabdf7a
update version extraction
rannick Jan 14, 2025
8b6e72e
Merge branch 'master' into fix_arriba
rannick Jan 20, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions modules/nf-core/arriba/arriba/main.nf
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,17 @@ process ARRIBA_ARRIBA {

conda "${moduleDir}/environment.yml"
container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ?
'https://depot.galaxyproject.org/singularity/arriba:2.4.0--h0033a41_2' :
'biocontainers/arriba:2.4.0--h0033a41_2' }"
'https://community-cr-prod.seqera.io/docker/registry/v2/blobs/sha256/fb/fbbd3ccedb1663939f2ca075a071e75b0d1c60f19a4cd46dd9ffe371f133105a/data' :
'community.wave.seqera.io/library/arriba:2.4.0--9680480f3735ac7f' }"


input:
tuple val(meta), path(bam)
tuple val(meta2), path(fasta)
tuple val(meta3), path(gtf)
path(blacklist)
path(known_fusions)
path(cytobands)
path(known_fusions)
path(protein_domains)

output:
Expand All @@ -27,10 +28,10 @@ process ARRIBA_ARRIBA {
script:
def args = task.ext.args ?: ''
def prefix = task.ext.prefix ?: "${meta.id}"
def blacklist = blacklist ? "-b $blacklist" : "-f blacklist"
def known_fusions = known_fusions ? "-k $known_fusions" : ""
def cytobands = cytobands ? "-d $cytobands" : ""
def protein_domains = protein_domains ? "-p $protein_domains" : ""
def arg_blacklist = blacklist ? "-b $blacklist" : "-f blacklist"
def arg_cytobands = cytobands ? "-d $cytobands" : ""
def arg_known_fusions = known_fusions ? "-k $known_fusions" : ""
def arg_protein_domains = protein_domains ? "-p $protein_domains" : ""

"""
arriba \\
Expand All @@ -39,10 +40,10 @@ process ARRIBA_ARRIBA {
-g $gtf \\
-o ${prefix}.fusions.tsv \\
-O ${prefix}.fusions.discarded.tsv \\
$blacklist \\
$known_fusions \\
$cytobands \\
$protein_domains \\
$arg_blacklist \\
$arg_cytobands \\
$arg_known_fusions \\
$arg_protein_domains \\
$args

cat <<-END_VERSIONS > versions.yml
Expand Down
8 changes: 4 additions & 4 deletions modules/nf-core/arriba/arriba/meta.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,14 @@ input:
type: file
description: Blacklist file
pattern: "*.{tsv}"
- - known_fusions:
type: file
description: Known fusions file
pattern: "*.{tsv}"
- - cytobands:
type: file
description: Cytobands file
pattern: "*.{tsv}"
- - known_fusions:
type: file
description: Known fusions file
pattern: "*.{tsv}"
- - protein_domains:
type: file
description: Protein domains file
Expand Down
5 changes: 5 additions & 0 deletions modules/nf-core/arriba/arriba/tests/nextflow.config
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
profiles {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be needed now. The issues with the CI runners have been resolved. Can you kindly remove this and retry the CI tests.

docker {
docker.runOptions = '-u $(id -u):$(id -g)'
}
}
process {
withName: STAR_GENOMEGENERATE {
ext.args = '--genomeSAindexNbases 11'
Expand Down
2 changes: 1 addition & 1 deletion modules/nf-core/arriba/download/environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ channels:
- conda-forge
- bioconda
dependencies:
- bioconda::arriba=2.4.0
- conda-forge::wget=1.21.4
11 changes: 5 additions & 6 deletions modules/nf-core/arriba/download/main.nf
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@ process ARRIBA_DOWNLOAD {

conda "${moduleDir}/environment.yml"
container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ?
'https://depot.galaxyproject.org/singularity/arriba:2.4.0--h0033a41_2' :
'biocontainers/arriba:2.4.0--h0033a41_2' }"

'https://community-cr-prod.seqera.io/docker/registry/v2/blobs/sha256/3b/3b54fa9135194c72a18d00db6b399c03248103f87e43ca75e4b50d61179994b3/data' :
'community.wave.seqera.io/library/wget:1.21.4--8b0fcde81c17be5e' }"
input:
val(genome)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is genome used in the wget command? Perhaps we could pass the path to the arriba database. Therefore, if the datbaase path changes or is updated (e.g. arriba_v2.5.0), we don't have to update the hardcoded https://github.com/suhrig/arriba/releases/download/v2.4.0/arriba_v2.4.0.tar.gz -O arriba_v2.4.0.tar.gz in the module, we just have to pass a new val(arriba_database).

So then, it would be: wget $arriba_database


Expand All @@ -30,20 +29,20 @@ process ARRIBA_DOWNLOAD {

cat <<-END_VERSIONS > versions.yml
"${task.process}":
arriba_download: \$(arriba -h | grep 'Version:' 2>&1 | sed 's/Version:\s//')
wget: \$(wget --version | head -1 | sed 's/GNU Wget //' | sed -E 's/(.*) built on darwin.*/\1/')
END_VERSIONS
"""

stub:
"""
touch blacklist_hg38_GRCh38_v2.4.0.tsv.gz
touch protein_domains_hg38_GRCh38_v2.4.0.gff3
touch cytobands_hg38_GRCh38_v2.4.0.tsv
touch protein_domains_hg38_GRCh38_v2.4.0.gff3
touch known_fusions_hg38_GRCh38_v2.4.0.tsv.gz

cat <<-END_VERSIONS > versions.yml
"${task.process}":
arriba_download: \$(arriba -h | grep 'Version:' 2>&1 | sed 's/Version:\s//')
wget: \$(wget --version | head -1 | sed 's/GNU Wget //' | sed -E 's/(.*) built on darwin.*/\1/')
END_VERSIONS
"""
}
2 changes: 2 additions & 0 deletions modules/nf-core/arriba/download/tests/main.nf.test
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ nextflow_process {
tag "arriba/download"

test("test-arriba-download") {
config "./nextflow.config"
when {
process {
"""
Expand All @@ -29,6 +30,7 @@ nextflow_process {
}

test("download - stub") {
config "./nextflow.config"

options "-stub"

Expand Down
8 changes: 4 additions & 4 deletions modules/nf-core/arriba/download/tests/main.nf.test.snap
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"known_fusions_hg38_GRCh38_v2.4.0.tsv.gz:md5,4f00f81ccb5f4db283f1a22b8b0da67c"
],
"4": [
"versions.yml:md5,98c69df5eaea5caf0b4af7b8d7af4893"
"versions.yml:md5,e94a685b433b6749e129af0f799f614c"
],
"blacklist": [
"blacklist_hg38_GRCh38_v2.4.0.tsv.gz:md5,e3098a4be51aece78aede64b55c39318"
Expand All @@ -30,14 +30,14 @@
"protein_domains_hg38_GRCh38_v2.4.0.gff3:md5,43c387a784ebeed71b4147076cebf978"
],
"versions": [
"versions.yml:md5,98c69df5eaea5caf0b4af7b8d7af4893"
"versions.yml:md5,e94a685b433b6749e129af0f799f614c"
]
}
],
"meta": {
"nf-test": "0.9.2",
"nextflow": "24.10.2"
"nextflow": "24.10.3"
},
"timestamp": "2024-12-16T01:46:32.110653034"
"timestamp": "2025-01-14T14:01:45.101697"
}
}
5 changes: 5 additions & 0 deletions modules/nf-core/arriba/download/tests/nextflow.config
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
profiles {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above! Thank you!

docker {
docker.runOptions = '-u $(id -u):$(id -g)'
}
}
Loading