Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable strict mode #164

Merged
merged 1 commit into from
Nov 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
265 changes: 264 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"node": "^18.19.1 || ^20.11.1 || >=22.0.0"
},
"scripts": {
"postinstall": "patch-package",
"ng": "ng",
"start-test": "start-server-and-test",
"deploy": "ng deploy --base-href=https://ngneat.github.io/helipopper/",
Expand Down Expand Up @@ -75,6 +76,7 @@
"karma-jasmine-html-reporter": "^1.5.0",
"lint-staged": "^9.2.0",
"ng-packagr": "^18.0.0",
"patch-package": "8.0.0",
"prettier": "2.8.8",
"serve": "^11.3.2",
"standard-version": "^8.0.2",
Expand Down
13 changes: 13 additions & 0 deletions patches/tippy.js++@popperjs+core+2.10.2.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/node_modules/tippy.js/node_modules/@popperjs/core/lib/types.d.ts b/node_modules/tippy.js/node_modules/@popperjs/core/lib/types.d.ts
index 11f9219..f971927 100644
--- a/node_modules/tippy.js/node_modules/@popperjs/core/lib/types.d.ts
+++ b/node_modules/tippy.js/node_modules/@popperjs/core/lib/types.d.ts
@@ -114,7 +114,7 @@ export declare type ModifierArguments<Options extends Obj> = {
options: Partial<Options>;
name: string;
};
-export declare type Modifier<Name, Options> = {
+export declare type Modifier<Name, Options extends object> = {
name: Name;
enabled: boolean;
phase: ModifierPhases;
14 changes: 7 additions & 7 deletions projects/ngneat/helipopper/src/lib/defaults.ts
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
import { TippyConfig } from './tippy.types';
import type { TippyProps } from './tippy.types';

type Variation = TippyConfig['variations'][0];
type Variation = Partial<TippyProps>;

export const tooltipVariation: Variation = {
theme: null,
theme: undefined,
arrow: false,
animation: 'scale',
trigger: 'mouseenter',
offset: [0, 5]
offset: [0, 5],
};

export const popperVariation: Variation = {
theme: 'light',
arrow: true,
offset: [0, 10],
animation: null,
animation: undefined,
trigger: 'click',
interactive: true
interactive: true,
};

export function withContextMenuVariation(baseVariation: Variation): Variation {
Expand All @@ -25,6 +25,6 @@ export function withContextMenuVariation(baseVariation: Variation): Variation {
placement: 'right-start',
trigger: 'manual',
arrow: false,
offset: [0, 0]
offset: [0, 0],
};
}
Loading
Loading