fix: enable strict mode #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
In this commit, we enable strict mode because it is required to generate correct type definition (`.d.ts`) files. These files differ depending on whether strict mode is enabled or disabled. Enabling strict mode allows `null|undefined` values to be provided by the parent component (e.g., `[tp]="null"`, which should be allowed), but the compiler removes `null|undefined` values from the binding. We also had to patch the `@popperjs/core` types due to a mistake in their definitions. This patch was necessary for successful compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we enable strict mode because it is required to generate correct type definition (
.d.ts) files. These files differ depending on whether strict mode is enabled or disabled. Enabling strict mode allowsnull|undefinedvalues to be provided by the parent component (e.g.,[tp]="null", which should be allowed), but the compiler removesnull|undefinedvalues from the binding.We also had to patch the
@popperjs/coretypes due to a mistake in their definitions. This patch was necessary for successful compilation.