doc: WeakSet and WeakMap comparison details
#56648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
assert
lpinca
approved these changes
Jan 19, 2025
jasnell
approved these changes
Jan 19, 2025
lpinca
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7bc2946 |
BridgeAR
reviewed
Jan 21, 2025
Comment on lines
+915
to
+916
| // + WeakSet { <items unknown> } | ||
| // - WeakSet { <items unknown> } |
There was a problem hiding this comment.
Suggested change
| // + WeakSet { <items unknown> } | |
| // - WeakSet { <items unknown> } | |
| // WeakSet { | |
| // <items unknown> | |
| // } |
| weakSet2.add(obj); | ||
|
|
||
| // Comparing different instances fails, even with same contents | ||
| assert.deepStrictEqual(weakSet1, weakSet2); | ||
| // AssertionError: Expected inputs to be strictly deep-equal: |
There was a problem hiding this comment.
Suggested change
| // AssertionError: Expected inputs to be strictly deep-equal: | |
| // AssertionError: Values have same structure but are not reference-equal: |
| weakSet2.add(obj); | ||
|
|
||
| // Comparing different instances fails, even with same contents | ||
| assert.deepStrictEqual(weakSet1, weakSet2); | ||
| // AssertionError: Expected inputs to be strictly deep-equal: |
There was a problem hiding this comment.
Suggested change
| // AssertionError: Expected inputs to be strictly deep-equal: | |
| // AssertionError: Values have same structure but are not reference-equal: |
Comment on lines
+1024
to
+1025
| // + WeakSet { <items unknown> } | ||
| // - WeakSet { <items unknown> } |
There was a problem hiding this comment.
Suggested change
| // + WeakSet { <items unknown> } | |
| // - WeakSet { <items unknown> } | |
| // WeakSet { | |
| // <items unknown> | |
| // } |
Thanks for the review @BridgeAR! My bad, not sure if I forgot pushing some commit, but I can create another PR real quick addressing the requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation of the comparison details of the
WeakMapandWeakSetas per the current behavior.Fixes #56640