Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming convention doc #822

Merged
merged 10 commits into from
Sep 26, 2024
Merged

Naming convention doc #822

merged 10 commits into from
Sep 26, 2024

Conversation

Sherwin-14
Copy link
Contributor

@Sherwin-14 Sherwin-14 commented Sep 21, 2024

This is the first draft for the contributing naming convention as discussed here


📚 Documentation preview 📚: https://earthaccess--822.org.readthedocs.build/en/822/

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.88%. Comparing base (fde4494) to head (2f49c08).
Report is 26 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #822      +/-   ##
==========================================
+ Coverage   73.64%   73.88%   +0.24%     
==========================================
  Files          31       31              
  Lines        1996     2003       +7     
==========================================
+ Hits         1470     1480      +10     
+ Misses        526      523       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you! In addition to a couple minor tweaks, would you mind resolving the conflicts in the changelog? If you have any trouble, happy to help.

docs/contributing/naming-convention.md Outdated Show resolved Hide resolved
docs/contributing/naming-convention.md Outdated Show resolved Hide resolved
docs/contributing/naming-convention.md Outdated Show resolved Hide resolved
docs/contributing/naming-convention.md Outdated Show resolved Hide resolved
docs/contributing/naming-convention.md Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, Sherwin!

@mfisher87 mfisher87 merged commit 412e947 into nsidc:main Sep 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants