-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naming convention doc #822
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
==========================================
+ Coverage 73.64% 73.88% +0.24%
==========================================
Files 31 31
Lines 1996 2003 +7
==========================================
+ Hits 1470 1480 +10
+ Misses 526 523 -3 ☔ View full report in Codecov by Sentry. |
db71711
to
fde4494
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Thank you! In addition to a couple minor tweaks, would you mind resolving the conflicts in the changelog? If you have any trouble, happy to help.
Co-authored-by: Matt Fisher <[email protected]>
…nages Co-authored-by: Matt Fisher <[email protected]>
Co-authored-by: Matt Fisher <[email protected]>
Co-authored-by: Matt Fisher <[email protected]>
…tarting with underscores Co-authored-by: Matt Fisher <[email protected]>
Co-authored-by: Matt Fisher <[email protected]>
b56eae0
to
2f49c08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, Sherwin!
This is the first draft for the contributing naming convention as discussed here
📚 Documentation preview 📚: https://earthaccess--822.org.readthedocs.build/en/822/