Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming convention doc #822

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,13 @@

- Added example PR links to pull request template
([#756](https://github.com/nsidc/earthaccess/issues/756))
[**@Sherwin-14**](https://github.com/betolink),
[**@Sherwin-14**](https://github.com/Sherwin-14),
[**@mfisher87**](https://github.com/mfisher87)


- Added Contributing Naming Convention document
([#532](https://github.com/nsidc/earthaccess/issues/532))
[**@Sherwin-14**](https://github.com/Sherwin-14),
[**@mfisher87**](https://github.com/mfisher87)

### Fixed

Expand Down
27 changes: 27 additions & 0 deletions docs/contributing/naming-convention.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Contributing Naming Convention

## General Guidelines

This document outlines the naming conventions for our project. These conventions are intended to promote consistency and clarity across different components.

### Specific Conventions

#### Python Code

**Style**: We follow the official Python Enhancement Proposal 8 [PEP8]((https://peps.python.org/pep-0008/#package-and-module-names) ) guidelines for naming conventions.

#### Jupyter Notebooks

**File Names**: File names should start with an underscore (_). Please use underscores instead of hyphens.

#### Documentation

**Directory and File Names**: Directory and file names should use hyphens (-) instead of underscores.

#### Tests

1. **Test File and Function Names**: Test files and functions should start with `test_`.
2. **Additional Guidelines**: For additional guidelines, please refer to the [pytest documentation](https://docs.pytest.org/en/stable/explanation/goodpractices.html#conventions-for-python-test-discovery).

!!! note "Test File Naming Convention"
We do not use the _test.py suffix for test files
1 change: 1 addition & 0 deletions mkdocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ nav:
- "Our meet-ups": "contributing/our-meet-ups.md"
- "Maintainers Guide": "contributing/maintainers-guide.md"
- "Code of Conduct": "contributing/code-of-conduct.md"
- "Contributing Naming Convention": "contributing/naming-convention.md"
- "Resources": "resources.md"
- USER GUIDE:
- "user_guide/index.md"
Expand Down
Loading