-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Implementation of SequentialCondition
#581
Merged
derekpierre
merged 9 commits into
nucypher:epic-sequential-condition
from
derekpierre:sequential-condition
Sep 30, 2024
Merged
Initial Implementation of SequentialCondition
#581
derekpierre
merged 9 commits into
nucypher:epic-sequential-condition
from
derekpierre:sequential-condition
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… This is not directly exported, but is used internally by other conditions. Update compound condition to use common condition schema.
… building blocks.
…s; It would be nice to have something common like this but I'm not sure how to do that currently. Explicitly define union of all conditions in compound and sequential modules.
…ted sequential conditions.
derekpierre
force-pushed
the
sequential-condition
branch
from
September 19, 2024 16:04
338536f
to
dd236ea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## epic-sequential-condition #581 +/- ##
============================================================
Coverage ? 89.32%
============================================================
Files ? 61
Lines ? 6230
Branches ? 330
============================================================
Hits ? 5565
Misses ? 664
Partials ? 1 ☔ View full report in Codecov by Sentry. |
…not provided for conditionVariables.
derekpierre
changed the title
[WIP] Sequential Condition
Initial Implementation of Sequential Condition
Sep 23, 2024
derekpierre
requested review from
KPrasch,
arjunhassard,
cygnusv,
theref,
vzotova and
manumonti
September 23, 2024 17:22
derekpierre
changed the title
Initial Implementation of Sequential Condition
Initial Implementation of Sep 23, 2024
SequentialCondition
vzotova
approved these changes
Sep 23, 2024
manumonti
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! LGTM 🙌
KPrasch
approved these changes
Sep 30, 2024
derekpierre
merged commit Sep 30, 2024
1d66bcd
into
nucypher:epic-sequential-condition
4 checks passed
derekpierre
added a commit
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Implementation of SequentialCondition from nucypher/nucypher#3500
Issues fixed/closed:
Why it's needed:
Notes for reviewers: