Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Implementation of SequentialCondition #581

Merged
merged 9 commits into from
Sep 30, 2024
Merged

Initial Implementation of SequentialCondition #581

merged 9 commits into from
Sep 30, 2024

Commits on Sep 19, 2024

  1. Use common condition schema for conditions that use multi-conditions.… 

    … This is not directly exported, but is used internally by other conditions.

Update compound condition to use common condition schema.
    @derekpierre
    derekpierre committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e6cb46e View commit details
    Browse the repository at this point in the history

  2. Add initial code for sequential conditions based on reuse of existing… 

    … building blocks.
    @derekpierre
    derekpierre committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    dadfdbd View commit details
    Browse the repository at this point in the history

  3. Remove multi-condition modules since circular dependency caused issue… 

    …s; It would be nice to have something common like this but I'm not sure how to do that currently.

Explicitly define union of all conditions in compound and sequential modules.
    @derekpierre
    derekpierre committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    1c4ce38 View commit details
    Browse the repository at this point in the history

  4. Update compound condition tests to check max operands and include nes… 

    …ted sequential conditions.
    @derekpierre
    derekpierre committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    dd236ea View commit details
    Browse the repository at this point in the history

  5. Use baseConditionSchema that all sub-types of conditions extend their… 

    … schema from.
    @derekpierre
    derekpierre committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d3ddf13 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Implement validation of nested depth limit for multi-condition types.

    @derekpierre
    derekpierre committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    87b14f9 View commit details
    Browse the repository at this point in the history

  2. Add test for checking nested depth limit for compound condition.

    @derekpierre
    derekpierre committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b440ad9 View commit details
    Browse the repository at this point in the history

  3. Initial tests for sequential conditions.

    @derekpierre
    derekpierre committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    ef53f6c View commit details
    Browse the repository at this point in the history

  4. Add sequential condition validation to ensure duplicate varNames are … 

    …not provided for conditionVariables.
    @derekpierre
    derekpierre committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3bd8816 View commit details
    Browse the repository at this point in the history