Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp to jsonschema #38

Merged
merged 7 commits into from
Sep 17, 2024
Merged

Add timestamp to jsonschema #38

merged 7 commits into from
Sep 17, 2024

Conversation

nvdaes
Copy link
Contributor

@nvdaes nvdaes commented Aug 13, 2024

Summary of the issue

Add-on metadata may accept a timestamp, to sort add-ons or perform other queries.

Development approach

  • Update the json schema to accept an optional "submissionTime", corresponding to a timestamp. We use milliseconds instead of seconds, in case similar values are added in the future, for a better comparison.
  • When creating a json file, the current time will be assigned to submissionTime.
  • Updated tests, removing the submissionTime before comparing actual and expected json files.

@seanbudd seanbudd marked this pull request as draft August 13, 2024 05:14
@nvdaes nvdaes marked this pull request as ready for review August 13, 2024 05:58
@nvdaes
Copy link
Contributor Author

nvdaes commented Aug 13, 2024

We can add the timestamp using Python, or with GitHub Actions. I'll try to use Python from this repo.

@nvdaes nvdaes marked this pull request as draft August 13, 2024 06:41
@nvdaes nvdaes marked this pull request as ready for review August 13, 2024 08:43
_validate/createJson.py Outdated Show resolved Hide resolved
_validate/addonVersion_schema.json Outdated Show resolved Hide resolved
_validate/addonVersion_schema.json Outdated Show resolved Hide resolved
_validate/createJson.py Outdated Show resolved Hide resolved
@nvdaes nvdaes marked this pull request as draft August 16, 2024 03:24
@nvdaes nvdaes marked this pull request as ready for review August 16, 2024 03:46
@nvdaes
Copy link
Contributor Author

nvdaes commented Aug 16, 2024

@seanbudd , we now use mktime to build a timestamp from gmtime.

Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nvdaes - we're going to hold off on merging until the other PRs are ready

@nvdaes
Copy link
Contributor Author

nvdaes commented Aug 29, 2024

I wil try to create a PR in NVda repo adding a combo box to the store settings to sort addons by date or alphabetically . This should be done, imo, in config.conf since it is related to all addons, in contrast with options to filter addons by fields in the store gui. I will start this weekend .

@seanbudd seanbudd merged commit 888b38f into nvaccess:main Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants