Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add action to upload a patch when bindings differ #1958

Merged
merged 10 commits into from
Dec 19, 2024

Conversation

Geometer1729
Copy link
Member

@Geometer1729 Geometer1729 commented Dec 18, 2024

I noticed there are a couple PRs failing the bindings check right now, and I know the exact way the bindings generate can be weird and flaky, so I added a workflow to upload the diff from ci, so you can easily download it and apply it.
Ideally it would comment it as a suggestion, but AFAIK that can't really work for submodules so I think this is the next best thing.

Sorry to make such a small pr, this should've been part of #1800

@Geometer1729 Geometer1729 marked this pull request as ready for review December 18, 2024 21:31
@Geometer1729 Geometer1729 requested a review from a team as a code owner December 18, 2024 21:31
@Geometer1729 Geometer1729 merged commit 1122d05 into main Dec 19, 2024
29 checks passed
@Geometer1729 Geometer1729 deleted the brian/bindings-diff branch December 19, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants