Adding new range check32 table implementation #2732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arithmetic results
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## sai/fixing-lookuprs-bug #2732 +/- ##
===========================================================
- Coverage 72.50% 72.49% -0.02%
===========================================================
Files 247 247
Lines 57706 57734 +28
===========================================================
+ Hits 41842 41852 +10
- Misses 15864 15882 +18 ☔ View full report in Codecov by Sentry. |
| @@ -275,4 +289,13 @@ impl<F: Field> FixedLookupTables<F> for LookupTable<F> { | |||
| .collect(), | |||
| } | |||
| } | |||
|
|
|||
| fn table_range_check_32() -> Self { | |||
There was a problem hiding this comment.
You really want to keep 2^32 * 4 bytes in memory? This is madness!
| @@ -554,6 +554,24 @@ pub trait InterpreterEnv { | |||
| self.lookup_2bits(value); | |||
| } | |||
|
|
|||
| // Adds a lookup to the ByteLookup table for each byte of a 32-bit value | |||
| fn lookup_32bits(&mut self, value: &Self::Variable) { | |||
There was a problem hiding this comment.
What are you trying to achieve here?
There was a problem hiding this comment.
- yeah, why is it not enough to have two 16bit tables?...
dannywillems
requested changes
Oct 27, 2024
|
Might be useful to have a look at #2395 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.