Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o1vm/riscv32im: being strict on scope and unsafe def #2913

Merged
merged 2 commits into from
Dec 28, 2024

o1vm/riscv32im: place correctly the unsafe keyword

ff89083
Select commit
Loading
Failed to load commit list.
Merged

o1vm/riscv32im: being strict on scope and unsafe def #2913

o1vm/riscv32im: place correctly the unsafe keyword
ff89083
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 26, 2024 in 0s

73.37% (+0.01%) compared to 41e4397

View this Pull Request on Codecov

73.37% (+0.01%) compared to 41e4397

Details

Codecov Report

Attention: Patch coverage is 56.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 73.37%. Comparing base (41e4397) to head (ff89083).

Files with missing lines Patch % Lines
o1vm/src/interpreters/riscv32im/interpreter.rs 56.00% 22 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           dw/o1vm-lookup-80limits    #2913      +/-   ##
===========================================================
+ Coverage                    73.36%   73.37%   +0.01%     
===========================================================
  Files                          259      259              
  Lines                        61542    61553      +11     
===========================================================
+ Hits                         45151    45166      +15     
+ Misses                       16391    16387       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.