Treat an empty features string as a no-op like Cargo does

Cargo.toml

@@ -29,7 +29,7 @@ termcolor_output = "1.0.1"
 cargo_metadata = "0.17.0"
 clap-cargo = { version = "0.10.0", features = ["cargo_metadata"] }
 ignore = "0.4.18"
-clap-verbosity-flag = "2.0.0"
+clap-verbosity-flag = { git = "https://github.com/HadrienG2/clap-verbosity-flag.git", branch = "implement-default" }
 log = "0.4.17"
 # Note that `tame-index` and `gix` must be upgraded in lock-step to retain the same `gix`
 # minor version. Otherwise, one will compile `gix` two times in different minor versions.

src/lib.rs

@@ -27,7 +27,7 @@ pub use query::{ActualSemverUpdate, RequiredSemverUpdate, SemverQuery};
 
 /// Test a release for semver violations.
 #[non_exhaustive]
-#[derive(Debug)]
+#[derive(Debug, PartialEq, Eq)]
 pub struct Check {
     /// Which packages to analyze.
     scope: Scope,
@@ -52,7 +52,7 @@ pub enum ReleaseType {
 }
 
 #[non_exhaustive]
-#[derive(Debug)]
+#[derive(Debug, PartialEq, Eq)]
 pub struct Rustdoc {
     source: RustdocSource,
 }
@@ -102,7 +102,7 @@ impl Rustdoc {
     }
 }
 
-#[derive(Debug)]
+#[derive(Debug, PartialEq, Eq)]
 enum RustdocSource {
     /// Path to the Rustdoc json file.
     /// Use this option when you have already generated the rustdoc file.
@@ -120,12 +120,12 @@ enum RustdocSource {
 }
 
 /// Which packages to analyze.
-#[derive(Default, Debug)]
+#[derive(Default, Debug, PartialEq, Eq)]
 struct Scope {
     mode: ScopeMode,
 }
 
-#[derive(Debug)]
+#[derive(Debug, PartialEq, Eq)]
 enum ScopeMode {
     /// All packages except the excluded ones.
     DenyList(PackageSelection),
@@ -140,7 +140,7 @@ impl Default for ScopeMode {
 }
 
 #[non_exhaustive]
-#[derive(Default, Clone, Debug)]
+#[derive(Default, Clone, Debug, PartialEq, Eq)]
 pub struct PackageSelection {
     selection: ScopeSelection,
     excluded_packages: Vec<String>,

src/main.rs

@@ -121,7 +121,7 @@ enum SemverChecksCommands {
     CheckRelease(CheckRelease),
 }
 
-#[derive(Debug, Args)]
+#[derive(Debug, Args, Default)]
 struct CheckRelease {
     #[command(flatten, next_help_heading = "Current")]
     pub manifest: clap_cargo::Manifest,
@@ -336,6 +336,10 @@ impl From<CheckRelease> for cargo_semver_checks::Check {
             check.with_heuristically_included_features();
         }
         let mut mutual_features = value.features;
+        // Treat --features="" as a no-op like cargo does
+        if mutual_features == [""] {
+            mutual_features.clear();
+        }
         let mut current_features = value.current_features;
         let mut baseline_features = value.baseline_features;
         current_features.append(&mut mutual_features.clone());
@@ -351,3 +355,17 @@ fn verify_cli() {
     use clap::CommandFactory;
     Cargo::command().debug_assert()
 }
+
+#[test]
+fn features_empty_string_is_no_op() {
+    use cargo_semver_checks::Check;
+    let without_features = CheckRelease::default();
+    let with_empty_features = CheckRelease {
+        features: vec!["".to_owned()],
+        ..CheckRelease::default()
+    };
+    assert_eq!(
+        Check::from(without_features),
+        Check::from(with_empty_features)
+    );
+}

src/rustdoc_gen.rs

@@ -229,7 +229,7 @@ pub(crate) enum CrateType<'a> {
 
 /// Configuration used to choose features to enable.
 /// Separate configs are used for baseline and current versions.
-#[derive(Debug, Clone, Serialize)]
+#[derive(Debug, Clone, Serialize, PartialEq, Eq)]
 pub(crate) struct FeatureConfig {
     /// Feature set chosen as the foundation.
     pub(crate) features_group: FeaturesGroup,
@@ -238,7 +238,7 @@ pub(crate) struct FeatureConfig {
     pub(crate) is_baseline: bool,
 }
 
-#[derive(Debug, Clone, Serialize)]
+#[derive(Debug, Clone, Serialize, PartialEq, Eq)]
 pub(crate) enum FeaturesGroup {
     All,
     Default,