Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'synapses restricted to region' #755

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

Clare72
Copy link
Contributor

@Clare72 Clare72 commented Aug 17, 2023

fixes #754

gouttegd
gouttegd previously approved these changes Aug 17, 2023
@Clare72
Copy link
Contributor Author

Clare72 commented Aug 18, 2023

also adding property chain over part_of (if neuron has synapses restricted to part of A, its synapses are also restricted to A)

src/ontology/ro-edit.owl Outdated Show resolved Hide resolved
@cmungall
Copy link
Contributor

Hmm, this is for smuggling in universal quantifications as existentials.

Owl already has a way of saying synapsed to ONLY region X.

We already snuggle with taxon constraints, there are many impracticalities and traps when using universals directly (I go as far as to say it's an anti pattern). For TCs we encode shortcuts. Should we do the same here?

Cc @d

@cmungall
Copy link
Contributor

Cc @dosumis

@cmungall
Copy link
Contributor

I'm not going to correct my typo above as I quite like the idea of snuggly taxon constraints 🧸

@addiehl
Copy link

addiehl commented Sep 11, 2023

Please incorporate the comments from issue #754.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update.

@github-actions github-actions bot added the stale label Feb 1, 2024
@Clare72
Copy link
Contributor Author

Clare72 commented Feb 7, 2024

@addiehl @anitacaron are you happy with this now?

src/ontology/ro-edit.owl Outdated Show resolved Hide resolved
@anitacaron anitacaron self-requested a review February 9, 2024 10:17
Copy link
Collaborator

@anitacaron anitacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, I approve. It still needs an ontology review.

Copy link
Contributor

This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update.

@github-actions github-actions bot added the stale label Jun 21, 2024
@github-actions github-actions bot removed the stale label Jun 22, 2024
@anitacaron anitacaron requested a review from cmungall July 15, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

relationship between an intrinsic neuron and its neuropil of innervation
5 participants