Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let ppx_tools build on OCaml 4.08/9/10/11 from one repository #85

Closed
wants to merge 4 commits into from

Conversation

avsm
Copy link
Contributor

@avsm avsm commented Jun 6, 2020

This switches the repository to be buildable using multiple versions of OCaml, in a manner similar to that used by Merlin and other compiler-dependent tools.

As a result, we can release a single ppx_tools package for multiple compiler versions. This in turn makes it much easier to use ppx_tools in dune monorepos, which makes life easier for benchmarking systems such as Sandmark used in multicore OCaml.

This PR applies over #82 and #84

kit-ty-kate and others added 4 commits April 22, 2020 21:07
Port work from Richard W.M. Jones. See ocaml-ppx#81
This switches the repository to be buildable using multiple
versions of OCaml, in a manner similar to that used by Merlin
and other compiler-dependent tools.

As a result, we can release a single ppx_tools package for
multiple compiler versions. This in turn makes it much easier
to use ppx_tools in dune monorepos, which makes life easier for
benchmarking systems such as Sandmark used in multicore OCaml.
@kit-ty-kate
Copy link
Collaborator

This PR has been merged as part of #86. Closing this. Thanks again!

@kit-ty-kate kit-ty-kate closed this Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants