Let ppx_tools build on OCaml 4.08/9/10/11 from one repository #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches the repository to be buildable using multiple versions of OCaml, in a manner similar to that used by Merlin and other compiler-dependent tools. As a result, we can release a single ppx_tools package for multiple compiler versions. This in turn makes it much easier to use ppx_tools in dune monorepos, which makes life easier for benchmarking systems such as Sandmark used in multicore OCaml.
|
No failures detected in the whole of opam-repository with this change. Merging. Thanks a lot! |
This was referenced Jul 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just takes @avsm's PR (#85), rebase it on top of master following the fix and merge of the OCaml 4.11 support (#82), but does not include #84 for now as it turns out to contain a slight issue. I'd like to go ahead and speed up the release process so I'm going to test reverse dependencies overnight with this PR and it should be ready to be merged for tomorrow.
After that I'll do a release (
ppx_tools.6.2) and will do another release once #84 is ready. @thierry-martinez does that sound ok to you?