-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CI workflow to build trunk-support
on trunk
#410
Conversation
Test whether `trunk-support` build on the `trunk` compiler once a day and on pushes and pull requests Signed-off-by: Samuel Hym <[email protected]>
Signed-off-by: Samuel Hym <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you, @shym!
I'm not sure about the badge either. The best way to find out is to merge and see.
# Every weekday, at 5:43 UTC | ||
- cron: '43 5 * * 1-5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the time you've chosen for the run!
[![Build on `trunk`](https://github.com/ocaml-ppx/ppxlib/actions/workflows/build.yml/badge.svg?branch=trunk-support)](https://github.com/ocaml-ppx/ppxlib/actions/workflows/build.yml) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure either here. I was expecting something like
[![Build on `trunk`](https://img.shields.io/github/workflow/status//ocaml-ppx/ppxlib/
<I don't know what>?branch=trunk-support)](https://github.com/ocaml-ppx/ppxlib/
actions/workflows/build.yml)
Let's merge what you've put and see if it works!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To follow up on this: It works! 🎉
Hello @pitag-ha, I was looking at the CHANGES.me file.
Instead of just:
|
@pitag-ha, my reason for this suggestion is that, if someone visits the CHANGES.me file, they should be able to see a summary of the |
Hi @marrious11, thanks for the suggestion! That's a good idea and, in fact, it's already the case. Let me explain. The purpose of the CHANGES.md is to generate the release notes when releasing Btw, just so you know: Outreachy applicants aren't expected to keep on working on the projects once the contribution period is over. And any contributions you do now, won't be taken into account in the intern selection process. Also, we don't want to take advantage of applicants working more on our projects than expected. That being said, if you'd love to keep on working on ppxlib/PPXs out of interest and to learn more, you're welcome to do so. I just wanted to be clear that it would only be for you to grow, not for the Outreachy process. |
Wow, @pitag-ha 🥲 I saw the release notes, they were awesome more than even what I thought it to be. About Outreachy: Yes, actually about contribution is over, I just wish to learn more and acquire software development skills in functional Programming with Ocaml. I believe that here in the community I will be able to learn as much as to prepare me to contribute professionally back to the community. With the Ocaml community:
|
Hey @marrious11, I've just moved our conversation over to the issue dedicated to Outreachy-related things and have answered your questions there. |
Adds an action that builds with the latest supported trunk. I heavily reused the work of @shym from ocaml-ppx#410, thank you for this contribution! Signed-off-by: Nathan Rebours <[email protected]>
This PR adds a CI workflow to build
trunk-support
on the latesttrunk
once a day and on updates on that branch. It also adds a badge to the README (hopefully I got those URLs right 🤔), which might help maintain the branch; and help users check whether possible issues were detected already.