Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CI workflow to build trunk-support on trunk #410

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Add a CI workflow to build trunk-support on trunk #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58ba23b
CI: Build ppxlib with the `trunk` compiler
shym Mar 24, 2023
19e0c84
README: Add a CI badge
shym Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
name: Build on `trunk`

on:
push:
pull_request:
schedule:
# Every weekday, at 5:43 UTC
- cron: '43 5 * * 1-5'
Comment on lines +7 to +8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the time you've chosen for the run!


jobs:
build:
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v2

- name: Pick up a robust cache prefix
id: setup
run: |
# Ensure that cache is flushed when trunk is updated
cache_prefix="$(git ls-remote https://github.com/ocaml/ocaml.git refs/heads/trunk | cut -f 1)"
echo "cache_prefix=$cache_prefix" >> "$GITHUB_OUTPUT"
cat "$GITHUB_OUTPUT"

- name: Install OCaml compiler
uses: ocaml/setup-ocaml@v2
with:
ocaml-compiler: 'ocaml-variants.5.1.0+trunk'
dune-cache: true
cache-prefix: ${{ steps.setup.outputs.cache_prefix }}

- name: Install ppxlib dependencies
run: |
opam install ./ppxlib.opam --deps-only

- name: Show configuration
run: |
opam exec -- ocamlc -config
opam config list
opam exec -- dune printenv
opam list

- name: Build the ppxlib
run: opam exec -- dune build -p ppxlib
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Non-continuous `trunk`-support for Ppxlib

[![Build on `trunk`](https://github.com/ocaml-ppx/ppxlib/actions/workflows/build.yml/badge.svg?branch=trunk-support)](https://github.com/ocaml-ppx/ppxlib/actions/workflows/build.yml)

Comment on lines +3 to +4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure either here. I was expecting something like

[![Build on `trunk`](https://img.shields.io/github/workflow/status//ocaml-ppx/ppxlib/
<I don't know what>?branch=trunk-support)](https://github.com/ocaml-ppx/ppxlib/
actions/workflows/build.yml)

Let's merge what you've put and see if it works!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To follow up on this: It works! 🎉

On this branch, we provide a Ppxlib version, which can be compiled with
OCaml's `trunk` branch. Whenever you want to compile a project that
(transitively) depends on PPXs with `trunk`, please pin Ppxlib to
Expand Down