-
Notifications
You must be signed in to change notification settings - Fork 98
dev meeting 20200625
Present at the meeting:
- Sonja Heinze (@pitag-ha)
- Carl Eastlund (@ceastlund)
- Jérémie Dimino (@jeremiedimino)
- Nathan Rebours (@NathanReb)
- Sonja continues porting project to ppxlib, starting with js_of_ocaml
- Carl remove the Base dependency of ppxlib and then switch to porting projects to ppxlib
- Nathan backports the driver configuration changes from ppx to ppxlib to prevent leaking parts of the OMP API that will go away in omp.2.0.0
- Nathan sends PR to the reverse dependencies for compatibility with the next ppxlib release
Sonja ported another rewriter in tyxml
as well as an internal code generator that depended on OMP. The PR
for tyxml should be ready now. She also started porting js_of_ocaml's rewriters. No big blockers arose so far.
Carl hasn't had time to work on PPX this week. He'll get back to the Base dependency drop when he has time again.
Nathan assembled a dune-workspace with ppxlib's reverse dependencies. For now it's done through a bash script but we're thinking about upstreaming this workflow into duniverse to make it more robust and available to other projects. Only a few of ppxlib's rev deps aren't JaneStreet owned and only one among those is breaking because of the 4.10 AST upgrade. Some of those weren't co-installable with JaneStreet PPXes because of upper bounds on base or on other JS libraries.
We have to consider how to deal with JaneStreet PPXes because if their release doesn't coincide with the ppxlib's release we might end up with a universe split between the JS PPXes and the other ppx-es. We'll have to include them in the upgrade process and patch their latest released version and release that patch along with ppxlib and the other PPXes.
Jérémie mentioned that some part of OMP.1 leaks through ppxlib and that those will go away with omp.2. As we test rev-deps for breakage we should make sure they will survive this change as well as the 4.10 AST upgrade. Nathan will take care of fixing this part of the API by backporting the corresponding changes from ocaml-ppx/ppx#88.
We should keep a list of the reverse dependencies we wish to help maintain, make sure they are co-installable and eventually provide a way for authors to ask for their project to be included to the list. The packages that are now being ported from OMP to ppxlib should be included into that list.