Fix generating sites modules failure when implicit_transitive_deps set to false #10650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HasanA <[email protected]>
MA0010
force-pushed
the
fix_generate_site
branch
from
2a11b98
to
e30ce41
Compare
nojb
reviewed
Jun 18, 2024
doc/changes/10650.md
Outdated
Comment on lines
2
to
3
| in order to avoid failure when generating and building sites modules | ||
| with implicit_transitive_deps = false. (#10650, @MA0100) |
There was a problem hiding this comment.
Please remove the extra leading whitespace.
Signed-off-by: HasanA <[email protected]>
MA0010
force-pushed
the
fix_generate_site
branch
from
dce2e02
to
fecdf7e
Compare
nojb
approved these changes
Jun 18, 2024
nojb
reviewed
Jun 18, 2024
Co-authored-by: Nicolás Ojeda Bär <[email protected]> Signed-off-by: HasanA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes an edit to allow building dune projects with
generate_sites_modulestanza, even whenimplicit_transitive_depsis set to false, which is the desired behavior.In short, when using
genereate_sites_modules, the modulesites.mlis generated havingdune-sitelibrary as a direct dependency, which in turn hasdune-sectionprivate library as a transitive dep. Sincedune-sectionis used explicitly insites.ml, the build fails whenimplicit_transitive_depsis set to false (even with dune supporting hidden deps, see #10644).Therefore, dune-section is re_exported in the stanza of dune-site in order to avoid this failure.
Fixes #9661