Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generating sites modules failure when implicit_transitive_deps set to false #10650

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Fix generating sites modules failure when implicit_transitive_deps set to false #10650

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e30ce41
re_export dune-section in dune-site stanza
MA0010 Jun 17, 2024
fecdf7e
add CHANGES file
MA0010 Jun 18, 2024
6116870
Merge branch 'main' into fix_generate_site
nojb Jun 18, 2024
e9b94e1
Update doc/changes/10650.md
MA0010 Jun 19, 2024
8b37f96
Merge branch 'main' into fix_generate_site
nojb Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/changes/10650.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Re_export dune-section private library in the dune-site library stanza,
in order to avoid failure when generating and building sites modules
with implicit_transitive_deps = false. (#10650, @MA0100)
MA0010 marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 3 additions & 1 deletion otherlibs/dune-site/src/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
(special_builtin_support
(dune_site
(data_module dune_site_data)))
(libraries dune-private-libs.dune-section dune-site.private)
(libraries
(re_export dune-private-libs.dune-section)
dune-site.private)
(instrumentation
(backend bisect_ppx)))
Loading