-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of Instrument list and Parameters creation #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks. Though this performance-driven variation in factory may add some confusion. I could imagine other solutions, but it makes sense to do this for now.
Refactoring in Instruments/Parameters creation. For optimisation and bug-fixing. This will really reduce the overhead and there will be no more gateway timeouts, I hope.
instr_name
andinstrument_query
are attached as attributes to theinstrument_factory
. This allows to avoid the creation of every Instrument in each request.Ontology
instance toParameter.from_owl_uri
in order to not recreate it.NOTE: one breaking change is introduced. The default KG url is removed, as the info in kg is really deployment-specific.