feat: drop support for Symfony 4.4 #141
Conversation
|
|
||
| <phpunit bootstrap="./vendor/autoload.php" colors="true"> |
There was a problem hiding this comment.
Can we keep the indentation? Thanks
There was a problem hiding this comment.
I am not sure which indentation you exatcly mean. I changed it, can you have a look if you want it like that, or please be more precisely.
Co-authored-by: Oskar Stark <[email protected]>
OskarStark
changed the title
There was a problem hiding this comment.
Can this Line be changed to run on push too?
That makes it easier to verify it on test runs in the fork.
First time contributers do not have to wait for a approval for a ci run.
|
Hello, thank you very much for your contribution. I agree that we can drop support for Symfony 4.4... As well as PHP < 8.0. But if we have no need or no new feature blocking (at least some test failing because of it, idk)... I don't like the idea of removing the support for it. |
|
I guess this PR should be splitted in separate PRs. |
|
Hi, I think this PR can be closed as #158 dropped support for Symfony 4.4? |
migrate phpunit config-format for v9.
Symfony 4.4 is no longer LTS https://symfony.com/releases/4.4 and should be droped in my eyes.
Any thoughts on dropping support of php < 8.0?