Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drop support for Symfony 4.4 #141

Closed
wants to merge 4 commits into from
Closed

feat: drop support for Symfony 4.4 #141

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b30490
feat: drop support of symfony < 5.4, migrate phpunit config-format fo…
Chris8934 Jan 28, 2023
928f095
Update CHANGELOG.md
Chris53897 Jan 28, 2023
cab3c90
feat: drop support of symfony < 5.4, migrate phpunit config-format fo…
Chris8934 Jan 28, 2023
acbc1b5
feat: drop support of symfony < 5.4, migrate phpunit config-format fo…
Chris8934 Jan 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/static.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
steps:
- uses: actions/checkout@master
- name: PHPStan
uses: docker://jakzal/phpqa:php8.0
uses: docker://jakzal/phpqa:php8.2
with:
args: phpstan analyze --no-progress

Expand All @@ -17,6 +17,6 @@ jobs:
steps:
- uses: actions/checkout@master
- name: PHP-CS-Fixer
uses: docker://jakzal/phpqa:php8.0
uses: docker://jakzal/phpqa:php8.2
with:
args: php-cs-fixer fix --config=.php_cs.dist.php --dry-run
8 changes: 4 additions & 4 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,18 @@ jobs:
matrix:
include:
- php: '7.4'
symfony-require: 4.4.*
symfony-require: 5.4.*
- php: '8.0'
symfony-require: 5.3.*
symfony-require: 5.4.*
- php: '8.0'
symfony-require: 6.0.*
stability: dev
- php: '8.1'
- php: '8.2'
fail-fast: false

steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- Remove support of symfony < 5.4 (5.4 is new LTS)
Chris53897 marked this conversation as resolved.
Show resolved Hide resolved

## [3.9.1] - 2023-01-16

### Fixed
Expand Down
14 changes: 7 additions & 7 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,18 @@
"require": {
"php": ">=7.4",
"giggsey/libphonenumber-for-php": "^8.0",
"symfony/framework-bundle": "^4.4|^5.3|^6.0",
"symfony/intl": "^4.4|^5.3|^6.0"
"symfony/framework-bundle": "^5.4|^6.0",
"symfony/intl": "^5.4|^6.0"
},
"require-dev": {
"doctrine/doctrine-bundle": "^1.12|^2.0",
"phpspec/prophecy-phpunit": "^2.0",
"phpunit/phpunit": "^9.5",
"symfony/form": "^4.4|^5.3|^6.0",
"symfony/property-access": "^4.4|^5.3|^6.0",
"symfony/serializer": "^4.4|^5.3|^6.0.1",
"symfony/twig-bundle": "^4.4|^5.3|^6.0",
"symfony/validator": "^4.4|^5.3|^6.0"
"symfony/form": "^5.4|^6.0",
"symfony/property-access": "^5.4|^6.0",
"symfony/serializer": "^5.4|^6.0.1",
"symfony/twig-bundle": "^5.4|^6.0",
"symfony/validator": "^5.4|^6.0"
},
"suggest": {
"doctrine/doctrine-bundle": "Add a DBAL mapping type",
Expand Down
27 changes: 16 additions & 11 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,19 @@
<?xml version="1.0" encoding="UTF-8"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
bootstrap="./vendor/autoload.php"
colors="true"
xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd">

<coverage>
<include>
<directory>src</directory>
</include>
</coverage>

<testsuites>
<testsuite name="MisdPhoneNumberBundle Test Suite">
<directory>tests</directory>
</testsuite>
</testsuites>

<phpunit bootstrap="./vendor/autoload.php" colors="true">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the indentation? Thanks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure which indentation you exatcly mean. I changed it, can you have a look if you want it like that, or please be more precisely.

<testsuites>
<testsuite name="MisdPhoneNumberBundle Test Suite">
<directory>tests</directory>
</testsuite>
</testsuites>
<filter>
<whitelist>
<directory>src</directory>
</whitelist>
</filter>
</phpunit>