-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Symfony 7 & drop support for unmaintained Symfony versions #158
Conversation
Close #157 What a timing. ;) |
Oh sorry, I think you pushed it after I checked if there was an opened PR 😅 |
No problem. ;) |
About PHP CS Fixer & PHPStan, what do you think about putting them in their own composer.json files in a tools directory? (can be done in a separate PR) I did it in WebpackEncore bundle & a few others in the past, see e.g. https://github.com/symfony/webpack-encore-bundle |
It avoid this kind of "problems" with docker images which are not (yet) up to date and it's pretty similar to what's proposed by cs-fixer, so it's OK for me! 👌 |
Would you prefer an other PR for this? |
Yes, if it's OK for you. :) |
Sure, I'll wait for this PR to be merged before :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this should be merge after #154 and in a new minor version.
# Conflicts: # CHANGELOG.md
Hi, may I ask for a new release? 😄 |
It's coming in #166! 👌 |
No description provided.