Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 7 & drop support for unmaintained Symfony versions #158

Merged
merged 8 commits into from
Nov 29, 2023

Conversation

jmsche
Copy link

@jmsche jmsche commented Nov 29, 2023

No description provided.

@odolbeau
Copy link
Owner

Close #157

What a timing. ;)

@jmsche
Copy link
Author

jmsche commented Nov 29, 2023

Oh sorry, I think you pushed it after I checked if there was an opened PR 😅

@odolbeau
Copy link
Owner

No problem. ;)

@jmsche
Copy link
Author

jmsche commented Nov 29, 2023

About PHP CS Fixer & PHPStan, what do you think about putting them in their own composer.json files in a tools directory? (can be done in a separate PR)

I did it in WebpackEncore bundle & a few others in the past, see e.g. https://github.com/symfony/webpack-encore-bundle

@odolbeau
Copy link
Owner

About PHP CS Fixer & PHPStan, what do you think about putting them in their own composer.json files in a tools directory? (can be done in a separate PR)

I did it in WebpackEncore bundle & a few others in the past, see e.g. https://github.com/symfony/webpack-encore-bundle

It avoid this kind of "problems" with docker images which are not (yet) up to date and it's pretty similar to what's proposed by cs-fixer, so it's OK for me! 👌

@jmsche
Copy link
Author

jmsche commented Nov 29, 2023

It avoid this kind of "problems" with docker images which are not (yet) up to date and it's pretty similar to what's proposed by cs-fixer, so it's OK for me! 👌

Would you prefer an other PR for this?

@odolbeau
Copy link
Owner

It avoid this kind of "problems" with docker images which are not (yet) up to date and it's pretty similar to what's proposed by cs-fixer, so it's OK for me! 👌

Would you prefer an other PR for this?

Yes, if it's OK for you. :)

@odolbeau odolbeau requested a review from Nek- November 29, 2023 14:29
@jmsche
Copy link
Author

jmsche commented Nov 29, 2023

Sure, I'll wait for this PR to be merged before :)

Copy link
Owner

@odolbeau odolbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, this should be merge after #154 and in a new minor version.

# Conflicts:
#	CHANGELOG.md
@odolbeau odolbeau merged commit 60c8166 into odolbeau:master Nov 29, 2023
6 checks passed
@jmsche jmsche deleted the allow-symfony-7 branch November 29, 2023 14:55
@jmsche
Copy link
Author

jmsche commented Dec 4, 2023

Hi, may I ask for a new release? 😄

@odolbeau
Copy link
Owner

odolbeau commented Dec 4, 2023

It's coming in #166! 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants