[FIX] pivot: finer grained cycle detection #5026
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce: - insert a fixed pivot (not dynamic!) - insert a new calculated measure - in the calculated measure formula, reference one of a cell which contains a header formula => the cell becomes a #CYCLE even though there's no circular dependendy between the calculated measure and the other dimension header Task: 4214188
|
|
hokolomopo
reviewed
Sep 27, 2024
| @@ -37,7 +37,8 @@ export function assertDomainLength(domain: Maybe<FunctionResultObject>[]) { | |||
|
|
|||
| export function addPivotDependencies( | |||
| evalContext: EvalContext, | |||
| coreDefinition: PivotCoreDefinition | |||
| coreDefinition: PivotCoreDefinition, | |||
| forMeasures: PivotCoreMeasure[] | |||
| ) { | |||
| //TODO This function can be very costly when used with PIVOT.VALUE and PIVOT.HEADER | |||
There was a problem hiding this comment.
unrelated: what's the state of this TODO ?
There was a problem hiding this comment.
Think it's still a todo until we find it to be a real bottleneck ;-)
| @@ -813,7 +817,7 @@ export const PIVOT = { | |||
| const pivotId = getPivotId(_pivotFormulaId, this.getters); | |||
| const pivot = this.getters.getPivot(pivotId); | |||
| const coreDefinition = this.getters.getPivotCoreDefinition(pivotId); | |||
| addPivotDependencies(this, coreDefinition); | |||
| addPivotDependencies(this, coreDefinition, coreDefinition.measures); | |||
There was a problem hiding this comment.
So now we can reference headers of PIVOT.HEADER() but not headers originating from a spread pivot formula if I understand the code correctly. Do you think there's any way we can make that work ?
There was a problem hiding this comment.
Do you think there's any way we can make that work ?
yes, but it'd be quite difficult I think. Every cell would need to be computed in the correct dependency order, when they are needed.
|
@robodoo r+ |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Steps to reproduce:
=> the cell becomes a #CYCLE even though there's no circular dependendy
between the calculated measure and the other dimension header
Task: 4214188
review checklist